Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release: v4.1.0 #615

Merged
merged 2 commits into from
Oct 11, 2023
Merged

release: v4.1.0 #615

merged 2 commits into from
Oct 11, 2023

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Oct 9, 2023 •
edited
Loading

⚠️ Waiting for backports:

  1. [stable4] Backport minor deps update to stable4 #616
  2. [stable4] feat: export isPasswordConfirmationRequired #617

4.1.0 - 2023-10-09

Added

  • isPasswordConfirmationRequired(): boolean function to replace deprecated OC.PasswordConfirmation.requiresPasswordConfirmation()

Fixed

  • Fix compatibility with @nextcloud/l10n@^2

Changed

  • Add package.json/exports
  • Move to nextcloud-libraries organization
  • Add ESLint for linting files
  • Dependency updates

@ShGKme ShGKme added the 2. developing Work in progress label Oct 9, 2023
@ShGKme ShGKme self-assigned this Oct 9, 2023
@ShGKme ShGKme added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 9, 2023
@ShGKme ShGKme marked this pull request as ready for review October 9, 2023 17:19
ChristophWurst
ChristophWurst reviewed Oct 10, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
susnux
susnux requested changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switch from vue 7.x to 8.x means this should be a breaking major release (5.0.0).

@susnux
Copy link
Contributor

susnux commented Oct 10, 2023

Maybe releasing d9117a0 as 4.1.0 and then release current master as 5.0.0

This way 27 and 28 can benefit from the changes.

@ShGKme ShGKme marked this pull request as draft October 10, 2023 16:00
@ShGKme ShGKme changed the base branch from master to stable4 October 10, 2023 16:01
@ShGKme
Copy link
Contributor Author

ShGKme commented Oct 10, 2023

PR is updated to be 4.1.0 release with changes not related to nextcloud/vue update

@ShGKme
Copy link
Contributor Author

ShGKme commented Oct 10, 2023

Major update moved to #618

@ShGKme
chore(README): add versions compatibility
fa17998 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
release: v4.1.0
e02c04f 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme marked this pull request as ready for review October 10, 2023 19:06
@susnux susnux merged commit 3306776 into stable4 Oct 11, 2023
5 checks passed
@susnux susnux deleted the release/v4.1.0 branch October 11, 2023 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@susnux susnux susnux approved these changes

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@Pytal Pytal Pytal approved these changes

@szaimen szaimen Awaiting requested review from szaimen

Assignees

@ShGKme ShGKme

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ShGKme @susnux @AndyScherzinger @ChristophWurst @JuliaKirschenheuter @Pytal