Fix @nextcloud/l10n/gettext import
#606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Pytal
approved these changes
Oct 5, 2023
susnux
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix tsconfig moduleResolution
moduleResolution: nodeis fornode v10..node v15(while engine isnode v20) and doesn't supportpackage.jsonfieldsimportsandexportshttps://www.typescriptlang.org/tsconfig#moduleResolution
Fix l10n import
@nextcloud/l10n/dist/gettext.jsis not the correct import according to itsexports: https://github.com/nextcloud-libraries/nextcloud-l10n/blob/609525946917bb3613773415966e2536484e66fe/package.json#L7-L18It results in an incorrect bundle where
import { getGettextBuilder } from '@nextcloud/l10n/dist/gettext.js'doesn't work on buildHow to test
Try to update to
@nextcloud/vue@8which uses@nextcloud/l10n@2, and build the server.For example, here: #605