Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): Make @nextcloud/typings a regular dependency #610

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

ChristophWurst
Copy link
Contributor

This ensures that dependents of @nextcloud/l10n get the typings.

This follows the suggestions of https://www.typescriptlang.org/docs/handbook/declaration-files/publishing.html#dependencies.

Fixes #609

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst added bug Something isn't working dependencies Pull requests that update a dependency file labels Apr 21, 2023
@ChristophWurst ChristophWurst self-assigned this Apr 21, 2023
@skjnldsv skjnldsv merged commit bffaaa9 into master Apr 21, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix/deps/nextcloud-typings-dependency branch April 21, 2023 08:03
@tcitworld
Copy link
Contributor

TIL :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dist files contain references to @nextcloud/typings put is not declared as peer dep
3 participants