Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint files using ESLint (+ add CI workflow) and move to all Typescript #555

Merged
merged 2 commits into from
Jul 11, 2023
Merged

Lint files using ESLint (+ add CI workflow) and move to all Typescript #555

merged 2 commits into from
Jul 11, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jul 11, 2023

  • Move jest tests to Typescript
    • Including the config
  • Lint all files using ESLint
  • Add CI workflow for ESLint

@susnux
chore: Move jest config and tests to Typescript
2ce37b6 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
chore: Lint Typescript files using ESLint and add CI workflow linting
7ce59f9 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
Copy link
Contributor Author

susnux commented Jul 11, 2023

Importing from dist for tests requires to disable the import/no-unresolved rule as it is not available yet.

✔️ fixed that.

@susnux susnux merged commit c173513 into master Jul 11, 2023
6 checks passed
@susnux susnux deleted the chore/jest+eslint branch July 11, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@susnux @skjnldsv