-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add newFileMenu and refactor library with rollup #420
Conversation
a168483
to
b78a6fc
Compare
This comment was marked as resolved.
This comment was marked as resolved.
b78a6fc
to
8e2dee6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge this PR if you must, but then I'm fully removing myself from this package
Is there a ticket we could reference for anyone who is not familiar with |
9ae7077
to
27f31f7
Compare
Here we go, I removed as much as unrelated things I could find @ChristophWurst |
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
27f31f7
to
7c1cd70
Compare
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
iconSvgInline?: string | ||
/** Existing icon css class */ | ||
iconClass?: string | ||
fileType: FileType |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@juliushaertl @PVince81 any of you know why we actually use that property?
It has been like that for years
https://github.com/nextcloud/server/blob/ac2bc2384efe3c15ff987b87a7432bc60d545c67/apps/files/js/newfilemenu.js#L204
https://github.com/nextcloud/server/blob/ac2bc2384efe3c15ff987b87a7432bc60d545c67/apps/files/js/newfilemenu.js#L110
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be a leftover from how we used to manage creation
owncloud/core@d386168#diff-4e16996e525fd1d3ef643308e0c2edbd87c0776afb54b426b3a21cad6fca1868L181
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we can drop this.
The only thing we need is icon, text, new file text string, ID and handler, no?
}, | ||
}, | ||
transformIgnorePatterns: [ | ||
'node_modules/(?!(abcde|fghij)/)', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧐
@nextcloud/server