feat: Initialize cached values later #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
requested review from
georgehrke,
ChristophWurst,
vinicius73 and
skjnldsv
skjnldsv
reviewed
Mar 16, 2023
| | Nextcloud.v24.OC; | ||
| declare var OC: Nextcloud.v23.OC | ||
| | Nextcloud.v24.OC | ||
| | Nextcloud.v25.OC; |
There was a problem hiding this comment.
v26 is not provided by @nextcloud/typings
skjnldsv
approved these changes
Mar 16, 2023
Currently the current user and the csrf token are initialized when the file is loaded, but this will fail when imported in tests without DOM or for SSR. So instead the cached values are loaded on the first usage. Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the current user and the csrf token are initialized when the file is loaded, but this will fail when imported in tests without DOM or for SSR (e.g. nextcloud-vue docs). So instead the cached values are loaded on the first usage.