feat: Add option to set a Nextcloud target version or parse the appinfo #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
force-pushed
the
feat/allow-parsing-appinfo
branch
from
bc528cb
to
54ad406
Compare
|
Conflicts |
susnux
force-pushed
the
feat/allow-parsing-appinfo
branch
from
54ad406
to
2315a46
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #164 +/- ##
==========================================
+ Coverage 77.19% 86.23% +9.04%
==========================================
Files 5 6 +1
Lines 57 109 +52
==========================================
+ Hits 44 94 +50
- Misses 13 15 +2 ☔ View full report in Codecov by Sentry. |
@skjnldsv resolved and added unit tests for 100% coverage of the added utils script |
|
Should we enable it by default on the global config? |
skjnldsv
approved these changes
Jul 6, 2023
I think this would be useful, what do you think @ChristophWurst ? (As you requested that feature in the first place) |
You can set a `targetVersion` option like `targetVersion: '25.0.0'` to only report deprecations / removals that happend before that version. Moreover you can also set `parseAppInfo: true` to parse the `appinfo/info.xml` from a Nextcloud app and only report deprecations / removals before the `max-version` of the Nextcloud dependency. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
feat/allow-parsing-appinfo
branch
from
2315a46
to
e780f8a
Compare
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #1, but I think parsing the appinfo is more helpful.
Summary
Allow to set a
targetVersionoption liketargetVersion: '25.0.0'to only report deprecations / removals that happend before that version.Moreover you can also set
parseAppInfo: trueto parse theappinfo/info.xmlfrom a Nextcloud app and only report deprecations / removals before themax-versionof the Nextcloud dependency.