Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: capitalization of errors in url params #795

Merged
merged 1 commit into from
Oct 24, 2020
Merged

fix: capitalization of errors in url params #795

merged 1 commit into from
Oct 24, 2020

Conversation

kripod
Copy link
Contributor

@kripod kripod commented Oct 22, 2020

Due to the bad casing of oAuthCallback and oAuthSignin, they couldn't have been caught properly by error handler mechanisms.

@vercel
Copy link

vercel bot commented Oct 22, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nextauthjs/next-auth/hxi3x2jv8
✅ Preview: https://next-auth-git-fix-oauth-error-casings.nextauthjs.vercel.app

@vercel vercel bot temporarily deployed to Preview October 22, 2020 17:55 Inactive
@iaincollins
Copy link
Member

Thanks for spotting and fixing!

@iaincollins iaincollins merged commit 64084d6 into nextauthjs:main Oct 24, 2020
@iaincollins iaincollins added the bug Something isn't working label Oct 24, 2020
@htunnicliff
Copy link

Is it possible to get this fix included in a patch release?

@kripod kripod deleted the fix-oauth-error-casings branch December 18, 2020 19:42
@balazsorban44
Copy link
Member

@htunnicliff hoping to release a canary version this month!

@github-actions
Copy link

github-actions bot commented Feb 1, 2021

🎉 This PR is included in version 3.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants