-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci): enable pnpm
caching in CI
#7332
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
@SauravMaheshkar is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
Thanks, but based on #6939 this actually showed a slowdown. 🤔 |
Ah sorry missed the PR. Closing this |
FWIW I left a comment on that PR that described why their analysis was flawed. |
FYI, I re-added caching as I can see node_modules being installed on every run, and I'm leaning towards that #6939 (comment) is a true statement. |
With cache (restore 19s + install 24s = total 43s): https://github.com/nextauthjs/next-auth/actions/runs/5144534075/jobs/9260949734 Without cache (restore 0s + install 86s = total 86s): https://github.com/nextauthjs/next-auth/actions/runs/5144363220/jobs/9260563249 Not sure why there was 24s of install with cache, but still 2x the speed, so the cache is definitely worth it! Duh... |
Changes made by this PR can be summarized as follows:
cache
andcache-dependency-path
argument to enable caching to speed up CI times.