Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(client): add text regarding 'logout' #2432

Merged
merged 2 commits into from
Jul 28, 2021
Merged

Conversation

ndom91
Copy link
Member

@ndom91 ndom91 commented Jul 27, 2021

Reasoning 💡

Added text with the term 'logout' in order to "fix" the most searched term without results according to our algolia analytics.

image

Checklist 🧢

  • Documentation
  • [ ] Tests
  • Ready to be merged

Affected issues 🎟

@vercel
Copy link

vercel bot commented Jul 27, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nextauthjs/next-auth/8L2iyLkyhU8EnPMQegBDtQitgmYx
✅ Preview: https://next-auth-git-ndom91-add-signout-text-nextauthjs.vercel.app

@github-actions github-actions bot added client Client related code hacktoberfest-docs Relates to documentation labels Jul 27, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2021

Codecov Report

Merging #2432 (177d520) into main (887cb00) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2432   +/-   ##
=====================================
  Coverage   9.90%   9.90%           
=====================================
  Files         84      84           
  Lines       1403    1403           
  Branches     395     395           
=====================================
  Hits         139     139           
  Misses      1038    1038           
  Partials     226     226           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 887cb00...177d520. Read the comment docs.

Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Been looking at this in the search analytics for a few weeks now. 😅 very good idea! You could try hinting this in other relevant places as well, and maybe do the same with other highly searched terms without results!

Feel free to create an issue with terms you cannot find a good place for and tag me so we can decide how to include those in the docs!

@vercel vercel bot temporarily deployed to Preview July 28, 2021 17:58 Inactive
@ndom91 ndom91 merged commit 0f460c2 into main Jul 28, 2021
@ndom91 ndom91 deleted the ndom91/add-signout-text branch July 28, 2021 18:10
mnphpexpert added a commit to mnphpexpert/next-auth that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Client related code hacktoberfest-docs Relates to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants