Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pages): typo in error messages #2265

Merged
merged 1 commit into from
Jun 28, 2021
Merged

Conversation

ndom91
Copy link
Member

@ndom91 ndom91 commented Jun 27, 2021

Reasoning 💡

Small fix in the strings that get displayed as error messages on the signin page. See lines 24-35.

Our prettier settings weren't applied to this page yet as far as I can tell, so all that is in here as well :/

Checklist 🧢

  • Documentation
  • Tests
  • Ready to be merged

Affected issues 🎟

@vercel
Copy link

vercel bot commented Jun 27, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nextauthjs/next-auth/5ghJdEHiTpVGqU6DnhGCfTRBTWVG
✅ Preview: https://next-auth-git-ndom91-chore-typos-signin-errors-nextauthjs.vercel.app

@github-actions github-actions bot added core Refers to `@auth/core` pages labels Jun 27, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #2265 (0b09fc1) into main (ad6c13c) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##            main   #2265      +/-   ##
========================================
- Coverage   9.97%   9.96%   -0.02%     
========================================
  Files         82      82              
  Lines       1393    1395       +2     
  Branches     393     395       +2     
========================================
  Hits         139     139              
- Misses      1028    1030       +2     
  Partials     226     226              
Impacted Files Coverage Δ
src/server/pages/signin.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad6c13c...0b09fc1. Read the comment docs.

@ndom91 ndom91 temporarily deployed to release June 27, 2021 18:58 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Refers to `@auth/core` pages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants