Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mongodb-adapter): prevent MongoDB client promise being cached #11393

Merged
merged 2 commits into from
Jul 21, 2024

Conversation

simonecervini
Copy link
Contributor

☕️ Reasoning

As @aldosch mentioned in this comment, we need to update the MongoDBAdapter to properly support the new best practices from the MongoDB Team.

Context: vercel/next.js#66977

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

📌 Resources

Copy link

vercel bot commented Jul 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2024 9:09am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Jul 21, 2024 9:09am

Copy link

vercel bot commented Jul 15, 2024

@simonecervini is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added adapters Changes related to the core code concerning database adapters mongodb @auth/mongodb-adapter labels Jul 15, 2024
Copy link

github-actions bot commented Jul 15, 2024

Broken Link Checker

0 broken links found. Links organised below by source page, or page where they were found.

Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@4b59e20). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11393   +/-   ##
=======================================
  Coverage        ?   39.93%           
=======================================
  Files           ?      179           
  Lines           ?    28686           
  Branches        ?     1250           
=======================================
  Hits            ?    11457           
  Misses          ?    17229           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simonecervini simonecervini marked this pull request as ready for review July 15, 2024 15:06
Copy link
Member

@ndom91 ndom91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, thanks for updating the docs too 🙏

EDIT: Not sure what the hubspot broken links are about.. I checked in the latest preview deploy and it does seem to work.. Lets :shipit: Fixed

@ndom91 ndom91 changed the title Prevent MongoDB client promise being cached fix(mongodb-adapter): prevent MongoDB client promise being cached Jul 21, 2024
@ndom91 ndom91 merged commit 0223e1f into nextauthjs:main Jul 21, 2024
13 of 15 checks passed
k3k8 pushed a commit to k3k8/next-auth that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adapters Changes related to the core code concerning database adapters mongodb @auth/mongodb-adapter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants