fix(core): invalid url error when using custom error page #11381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
@apteryxxyz is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
|
@apteryxxyz Could you open an issue with a minimal reproduction first? 🙏 |
balazsorban44
approved these changes
Aug 9, 2024
|
@ThangHuuVu I think this should be reasonable. On server-side, we don't have the origin url and relative redirects won't work, so I think OP is right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
When a configuration error occurs and there is a custom error page (
pages.errorconfig option),@auth/coredoes not currently prepend the url origin to the path before passing it toResponse.redirect, resulting in an invalid URL error.Passing the full URL into the
pages.errorconfig option would fix this.This PR copys the URL building code used to handle other error types, and adds it to the configuration error handling.
🧢 Checklist
🎫 Affected issues
📌 Resources