fix(core): invalid url error when using custom error page #11381
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
When a configuration error occurs and there is a custom error page (
![image](https://private-user-images.githubusercontent.com/40654585/348464431-1286ceb0-fee2-4499-b73d-30b3a40805dd.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ1OTE0MTEsIm5iZiI6MTcyNDU5MTExMSwicGF0aCI6Ii80MDY1NDU4NS8zNDg0NjQ0MzEtMTI4NmNlYjAtZmVlMi00NDk5LWI3M2QtMzBiM2E0MDgwNWRkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODI1VDEzMDUxMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWJkZDI1ZTNkZjkyMzc1NjY2NTZiZjI4NWY0ODZmN2Q2MmViMzJjZTYzMzQxOTU3Mzc0NjBhN2U5Y2NjYWU5MDImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.ajpv8AaKJHLlKK56_qo8IjzO9fmsSj8BGgiwHDSHN9Q)
pages.error
config option),@auth/core
does not currently prepend the url origin to the path before passing it toResponse.redirect
, resulting in an invalid URL error.Passing the full URL into the
pages.error
config option would fix this.This PR copys the URL building code used to handle other error types, and adds it to the configuration error handling.
🧢 Checklist
🎫 Affected issues
📌 Resources