-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(providers): Add Loops Email Provider and Documentation #11197
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
@Whats-A-MattR is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
Pls approve. |
Thanks, this looks great! I made some tiny edits regarding the Could you update the svelte examples (in both mdx files) regarding the environment variables? Unfortunately SvelteKit doesn't expose a Soemthing like: import { SvelteKitAuth } from "@auth/sveltekit"
import Loops from "@auth/sveltekit/providers/loops"
import { env } from "$env/dynamic/prviate"
export const { handle, signIn, signOut } = SvelteKitAuth({
providers: [
Loops({
apiKey: env.AUTH_LOOPS_KEY,
transactionalId: env.AUTH_LOOPS_TRANSACTIONAL_ID,
})
]
}) |
Hey, @ndom91 I've updated in-line with the docs provided by Svelte |
@ndom91 Hey, how are we feeling about merging this one? |
export type LoopsUserConfig = Omit<Partial<LoopsConfig>, "options" | "type"> | ||
|
||
export default function Loops(config: LoopsUserConfig): LoopsConfig { | ||
if (!config.transactionalId) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If transactionalId
is required, let's not make it optional in the types 👍
☕️ Reasoning
Email / Magic Token Auth is great.
Loops.so make a great product for Email that goes beyond just transactional emails, I use them as my provider and love the platform.
🧢 Checklist
🎫 Affected issues
Fixes: This Feature Request
📌 Resources