Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(providers): Add Loops Email Provider and Documentation #11197

Open
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

Whats-A-MattR
Copy link

☕️ Reasoning

Email / Magic Token Auth is great.
Loops.so make a great product for Email that goes beyond just transactional emails, I use them as my provider and love the platform.

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

Fixes: This Feature Request

📌 Resources

Copy link

vercel bot commented Jun 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 23, 2024 6:36pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Aug 23, 2024 6:36pm

Copy link

vercel bot commented Jun 18, 2024

@Whats-A-MattR is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

@Whats-A-MattR Whats-A-MattR changed the title Add Loopa.so as Email Provider Add Loops.so as Email Provider Jun 18, 2024
@Whats-A-MattR Whats-A-MattR changed the title Add Loops.so as Email Provider Add Loops.so Email Provider and Documentation Jun 18, 2024
@github-actions github-actions bot added providers core Refers to `@auth/core` labels Jun 18, 2024
@Whats-A-MattR Whats-A-MattR marked this pull request as ready for review June 18, 2024 06:40
@Whats-A-MattR Whats-A-MattR changed the title Add Loops.so Email Provider and Documentation Add Loops Email Provider and Documentation Jun 18, 2024
@Whats-A-MattR Whats-A-MattR changed the title Add Loops Email Provider and Documentation Feat(providers): Add Loops Email Provider and Documentation Jun 18, 2024
@Whats-A-MattR
Copy link
Author

Pls approve.

@ndom91
Copy link
Member

ndom91 commented Jul 21, 2024

Thanks, this looks great! I made some tiny edits regarding the loops.svg image file.

Could you update the svelte examples (in both mdx files) regarding the environment variables? Unfortunately SvelteKit doesn't expose a process.env. You have to either import env or the variables themselves. More details. I realize this needs updated on the other magic link providers docs as well.

Soemthing like:

import { SvelteKitAuth } from "@auth/sveltekit"
import Loops from "@auth/sveltekit/providers/loops"
import { env } from "$env/dynamic/prviate"

export const { handle, signIn, signOut } = SvelteKitAuth({
  providers: [
    Loops({
      apiKey: env.AUTH_LOOPS_KEY,
      transactionalId: env.AUTH_LOOPS_TRANSACTIONAL_ID,
    })
  ]
})

@Whats-A-MattR
Copy link
Author

Hey, @ndom91 I've updated in-line with the docs provided by Svelte
https://learn.svelte.dev/tutorial/env-static-private

@Whats-A-MattR
Copy link
Author

@ndom91 Hey, how are we feeling about merging this one?

export type LoopsUserConfig = Omit<Partial<LoopsConfig>, "options" | "type">

export default function Loops(config: LoopsUserConfig): LoopsConfig {
if (!config.transactionalId)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If transactionalId is required, let's not make it optional in the types 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Refers to `@auth/core` providers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants