-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github and Discord providers ship incorrect SVGs that blend in with the background colour. #10481
Comments
This issue was marked with the This means that it is a good candidate for someone interested in contributing to the project, but does not know where to start. Have a look at the Contributing Guide first. This will help you set up your development environment to get started. When you are ready, open a PR, and link back to this issue in the form of adding Please make sure that - if applicable - you add tests for the changes you make. If you have any questions, feel free to ask in the comments below or the PR. Generally, you don't need to Note There is no need to ask for permission "can I work on this?" Please, go ahead if there is no linked PR 🙂 |
Seems like this issue has been resolved with #10542 standardising the bg colour for all providers |
@Bisxsh Bro. I don't think the issue is solved because the problem appears to be still there. |
@abhishekjaiswar221 The fix went in for next-auth@5.0.0-beta.17. |
Hello @Bisxsh, Thank you for filling me in with that version thing. I was unaware of it, and I will absolutely create an issue in their repo to upgrade the version of next-auth to the most recent version. |
Provider type
Discord, GitHub
Environment
System:
OS: Windows 11 10.0.22631
CPU: (8) x64 11th Gen Intel(R) Core(TM) i5-11300H @ 3.10GHz
Memory: 1.06 GB / 7.79 GB
Binaries:
Node: 20.9.0 - C:\Program Files\NodeJs\node.EXE
Yarn: 1.22.19 - D:\JSpiders Institute\Piyush Garg Code\piyushgarg-dev\node_modules.bin\yarn.CMD
npm: 9.8.1 - C:\Program Files\NodeJs\npm.CMD
pnpm: 8.14.2 - ~\AppData\Roaming\npm\pnpm.CMD
Browsers:
Edge: Chromium (123.0.2420.65)
Internet Explorer: 11.0.22621.1
npmPackages:
next: ^13.1.1 => 13.4.5
next-auth: ^4.18.10 => 4.22.1
react: 18.2.0 => 18.2.0
Reproduction URL
https://github.com/piyushgarg-dev/piyushgargdev-nextjs/blob/main/pages/api/auth/%5B...nextauth%5D.js
Describe the issue
The SVGs that are delivered by Github and Discord providers are wrong and mix in with the background colour.
It appears that instead of providing light SVG's in dark mode, the providers are shipping dark SVG's in dark mode.
How to reproduce
Go to https://www.piyushgarg.dev/
Click Login in the navigation bar.
Expected behavior
The providers should ship light SVGs in dark mode and dark SVGs in light mode.
The text was updated successfully, but these errors were encountered: