Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add light and dark mode repo banner images #968

Merged
merged 3 commits into from
Feb 21, 2023

Conversation

jbeveland27
Copy link
Contributor

@jbeveland27 jbeveland27 commented Feb 8, 2023

Adds updated banner images with the new logo and also includes light/dark modes.

Preview

The category image below will be displayed in light or dark mode depending on your GitHub settings.

A New Relic Open Source community project banner. It highlights that this repo is an official New Relic open source community project, supported by a maintainer(s) within New Relic.

Here's how that preview works (note: this uses images stored in the open-source-office repo just for example, because these images aren't merged into the opensource-website repo yet)

<a href="https://opensource.newrelic.com/oss-category/#community-project">
  <picture>
    <source
      media="(prefers-color-scheme: dark)"
      srcset="https://github.com/newrelic/open-source-office/raw/main/examples/categories/images/dark/Community_Project.png">
    <img
      alt="A New Relic Open Source community project banner. It highlights that this repo is an official New Relic open source community project, supported by a maintainer(s) within New Relic."
      src="https://github.com/newrelic/open-source-office/raw/main/examples/categories/images/Community_Project.png">
  </picture>
</a>

Follow up

* The copy snippets located in the wiki need to be updated as well to take advantage of the light/dark mode capability
* Update the repolinter rulesets with the new copy snippets

@gatsby-cloud
Copy link

gatsby-cloud bot commented Feb 8, 2023

✅ opensource-website-develop deploy preview ready

@jbeveland27
Copy link
Contributor Author

jbeveland27 commented Feb 20, 2023

Follow up items have been completed.

  • The change to docs/Open-Source-Category-Snippets.md will update the wiki once the docs workflow runs (post-merge).
  • The repolinter rulesets are updated in this PR to check for the new copy snippets and the fixes that are raised in the repolinter issue point to this repo's wiki as the common place to find the authoritative copy snippets. I'll merge that PR once this one is merged.

@clarkmcadoo
Copy link
Contributor

hey @jbeveland27, i guess these are meant to be html snippets, can we wrap them in an html code fence?

@jbeveland27 jbeveland27 merged commit 06ba4f3 into develop Feb 21, 2023
@jbeveland27 jbeveland27 deleted the feat/oss-category-images branch February 21, 2023 16:13
@nr-opensource-bot
Copy link
Contributor

🎉 This PR is included in version 1.24.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants