feat: final adjustments, refactored main view, MainMenu component stable

newrelic · Jul 20, 2020 · 73deb80 · 73deb80
1 parent 2f23fee
commit 73deb80
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 8 deletions.
diff --git a/nerdlets/network-telemetry-overview/MainMenu.jsx b/nerdlets/network-telemetry-overview/MainMenu.jsx
@@ -33,7 +33,7 @@ export default class MainMenu extends React.Component {
     this.handleAccountChange = this.handleAccountChange.bind(this);
   }
 
-  handleDataSourceChange = value => {
+  handleDataSourceChange = (evt, value) => {
     const dataSource = parseInt(value, 10);
     nerdlet.setUrlState({ dataSource });
   };
@@ -87,10 +87,7 @@ export default class MainMenu extends React.Component {
         <BlockText type={BlockText.TYPE.NORMAL}>
           <strong>Source</strong>
         </BlockText>
-        <RadioGroup
-          onChange={() => this.handleDataSourceChange(dataSource)}
-          value={`${dataSource}`}
-        >
+        <RadioGroup onChange={this.handleDataSourceChange} value={`${dataSource}`}>
           {DATA_SOURCES.map((v, i) => (
             <Radio key={i} label={v.name} value={`${i}`} />
           ))}
@@ -103,8 +100,6 @@ export default class MainMenu extends React.Component {
           label='Hide Labels'
           onChange={this.handleHideLabelsChange}
         />
-        <br />
-        <br />
 
         <BlockText type={BlockText.TYPE.NORMAL}>
           <strong>Limit results to about...</strong>

diff --git a/nerdlets/network-telemetry-overview/network-telemetry-nerdlet.jsx b/nerdlets/network-telemetry-overview/network-telemetry-nerdlet.jsx
@@ -112,7 +112,10 @@ export default class NetworkTelemetryNerdlet extends React.Component {
             <div className='main-container'>
               {isLoading && account.id && <Spinner fillContainer />}
               {!account.id && accountsList.length > 0 && this.renderSelectAccountAlert()}
-              {!account.id && accountsList.length === 0 && this.renderAccountsListError()}
+              {!account.id &&
+                accountsList.length === 0 &&
+                !isLoading &&
+                this.renderAccountsListError()}
               {!isLoading && account.id && this.renderDSComponent()}
             </div>
           </GridItem>

diff --git a/nerdlets/network-telemetry-overview/styles.scss b/nerdlets/network-telemetry-overview/styles.scss
@@ -166,6 +166,7 @@ label {
 
 .checkbox {
   margin-right: 5px;
+  margin-bottom: 10px;
   -webkit-box-align: center;
   align-items: center;
 }