Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert 'test/unit/errors/error-event-aggregator.test.js' to tap-style #1681

Closed
mrickard opened this issue Jun 20, 2023 · 2 comments · Fixed by #1683
Closed

Convert 'test/unit/errors/error-event-aggregator.test.js' to tap-style #1681

mrickard opened this issue Jun 20, 2023 · 2 comments · Fixed by #1683
Labels
dev:tests Indicates only changes to tests enhancement points: 1 1 day or less

Comments

@mrickard
Copy link
Member

Feature Description

The test test/unit/errors/error-event-aggregator.test.js uses mocha, but should be rewritten to use tap.
@workato-integration
Copy link

https://issues.newrelic.com/browse/NEWRELIC-9409

@mrickard mrickard added enhancement points: 3 A few days dev:tests Indicates only changes to tests points: 1 1 day or less and removed feature-request needs-triage points: 3 A few days labels Jun 20, 2023
@mrickard mrickard mentioned this issue Jun 21, 2023
Merged
@workato-integration
Copy link

Jira CommentId: 219283
Commented by mrickard:

PR: #1683

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev:tests Indicates only changes to tests enhancement points: 1 1 day or less
Projects
Node.js Engineering Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(testing): Converted error-event-aggregator.test.js to tap mrickard/node-newrelic
1 participant
@mrickard