Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in handler import module & add tests #172

Merged
merged 2 commits into from
Jul 18, 2023
Merged

Fix bug in handler import module & add tests #172

merged 2 commits into from
Jul 18, 2023

Conversation

hmstepanek
Copy link
Contributor

@hmstepanek hmstepanek commented Jul 17, 2023 •
edited
Loading

mrickard
mrickard reviewed Jul 17, 2023
View reviewed changes
Copy link
Member

@mrickard mrickard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hmstepanek I think you may need to amend the commit to sign it (and force-push the amended commit).

@hmstepanek hmstepanek force-pushed the fix-bug-in-import branch 2 times, most recently from 0052aae to 40101ba Compare July 17, 2023 19:32
@hmstepanek
Fix bug in handler import module
ac25f87 
Signed-off-by: Hannah Stepanek <hstepanek@newrelic.com>
@hmstepanek hmstepanek changed the title Fix bug in handler import module Fix bug in handler import module & add tests Jul 18, 2023
@umaannamalai umaannamalai merged commit c12de00 into master Jul 18, 2023
4 checks passed
@TimPansino TimPansino deleted the fix-bug-in-import branch July 20, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrickard mrickard mrickard approved these changes

@umaannamalai umaannamalai umaannamalai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hmstepanek @mrickard @umaannamalai