Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate missing async externals when Spring Reactor is in use #1780

Closed
kford-newrelic opened this issue Mar 4, 2024 · 3 comments · Fixed by #1883
Closed

Investigate missing async externals when Spring Reactor is in use #1780

kford-newrelic opened this issue Mar 4, 2024 · 3 comments · Fixed by #1883
Assignees
Labels
2 Story Point Estimate spike Research spike. Technical solution needing discovery

Comments

@kford-newrelic
Copy link
Contributor

Description

Customer reported issue:

We just tested the latest APM agent (8.8.1) and we’re still facing the instrumentation gap issue.For context, in all of our services the APM agent seems to be working fine, but we have 1 service which is a bit more complex (heavier reactor usage and more external webservice calls) in which we don’t see all the external calls. The call flow is typical :Spring mvc controller -> Business logic service (where we chain a lot of reactor Fluxes and Monos) -> External service webclientOur traces stop at the controller except for 1 webservice call that we execute at the very start of our reactor chain in the business logic service, all the other calls are absent from the traces.Relevant dependencies :

  • spring boot 2.5.14
  • spring mvc, webflux 5.3.20
  • reactor-netty-(http & core) 1.0.19
  • reactor-core (3.4.18)

Acceptance Criteria

Discovery spike.

Design Consideration/Limitations

Possible unexpected thread hop?

Dependencies

N/A

Additional context

Customer repro available

@workato-integration
Copy link

@kford-newrelic kford-newrelic added 2 Story Point Estimate spike Research spike. Technical solution needing discovery labels Mar 4, 2024
@jbedell-newrelic jbedell-newrelic self-assigned this Mar 5, 2024
@jbedell-newrelic
Copy link
Contributor

Closing this Spike out with the results detailed in #1800

@jbedell-newrelic
Copy link
Contributor

The fix here did resolve part of the issue, but more complex call-chaining is still not working. So, I'm re-opening this ticket to investigate further. We also believe this may be related to: #1450

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 Story Point Estimate spike Research spike. Technical solution needing discovery
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants