Skip to content
This repository has been archived by the owner on Dec 8, 2023. It is now read-only.

chore: repo-linter-checks #53

Merged
merged 4 commits into from
Mar 3, 2022
Merged

chore: repo-linter-checks #53

merged 4 commits into from
Mar 3, 2022

Conversation

jpvajda
Copy link

@jpvajda jpvajda commented Mar 1, 2022

  • This PR resolve the issues reported by repo-linter for OSS policies
  • I also made markdown linter fixes
  • this also adds a release.yml file

@jpvajda jpvajda linked an issue Mar 1, 2022 that may be closed by this pull request
@gatsby-cloud
Copy link

gatsby-cloud bot commented Mar 1, 2022

Gatsby Cloud Build Report

instant-observability-website

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 27s

Performance

Lighthouse report

Metric Score
Performance 🔶 26
Accessibility 🔶 89
Best Practices 🔶 87
SEO 🔶 76

🔗 View full report

README.md Outdated Show resolved Hide resolved
@jpvajda jpvajda linked an issue Mar 2, 2022 that may be closed by this pull request
3 tasks
Copy link
Contributor

@aswanson-nr aswanson-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I don't think we need the generate-changelog job unless that's also required

.github/workflows/release.yml Outdated Show resolved Hide resolved
Comment on lines 100 to 120
- name: Re-enable "required_pull_request_reviews" branch protection
id: enable-branch-protection
if: always()
uses: actions/github-script@v1
with:
github-token: ${{ secrets.OPENSOURCE_BOT_TOKEN }}
previews: luke-cage-preview
script: |
const result = await github.repos.updateBranchProtection({
owner: context.repo.owner,
repo: context.repo.repo,
branch: 'main',
required_status_checks: null,
restrictions: null,
enforce_admins: true,
required_pull_request_reviews: {
dismiss_stale_reviews: true,
required_approving_review_count: 1
}
})
console.log("Result:", result)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: Re-enable "required_pull_request_reviews" branch protection
id: enable-branch-protection
if: always()
uses: actions/github-script@v1
with:
github-token: ${{ secrets.OPENSOURCE_BOT_TOKEN }}
previews: luke-cage-preview
script: |
const result = await github.repos.updateBranchProtection({
owner: context.repo.owner,
repo: context.repo.repo,
branch: 'main',
required_status_checks: null,
restrictions: null,
enforce_admins: true,
required_pull_request_reviews: {
dismiss_stale_reviews: true,
required_approving_review_count: 1
}
})
console.log("Result:", result)
- name: Re-enable "required_pull_request_reviews" branch protection
id: enable-branch-protection
if: always()
uses: actions/github-script@v1
with:
github-token: ${{ secrets.OPENSOURCE_BOT_TOKEN }}
previews: luke-cage-preview
script: |
const result = await github.repos.updateBranchProtection({
owner: context.repo.owner,
repo: context.repo.repo,
branch: 'main',
required_status_checks: null,
restrictions: null,
enforce_admins: true,
required_pull_request_reviews: {
dismiss_stale_reviews: true,
required_approving_review_count: 1
}
})
console.log("Result:", result)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aswanson-nr is this any different? I'm seeing this error when trying to commit

Suggestion cannot be identical to original text.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me take a look

Copy link
Contributor

@aswanson-nr aswanson-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed on the changelog! Just need a few changes to the branch protection

.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
@aswanson-nr
Copy link
Contributor

aswanson-nr commented Mar 3, 2022

Not sure what happened with those comments, but this is what needs to be added to the "re-enable branch protection" step

required_status_checks: {
  strict: false,
  contexts: [
     'Gatsby Build Service - instant-observability-website'
  ]
},

@jpvajda
Copy link
Author

jpvajda commented Mar 3, 2022

@aswanson-nr I made the suggested change, let me know what you think. Thanks for the input here!

@aswanson-nr aswanson-nr merged commit 8bab1d8 into main Mar 3, 2022
@aswanson-nr aswanson-nr deleted the oss-policy-fix branch March 3, 2022 19:10
@nr-opensource-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[I/O site] Site doesn't have a 3rd party notice file [Repolinter] Open Source Policy Issues
4 participants