-
Notifications
You must be signed in to change notification settings - Fork 20
Conversation
jpvajda
commented
Mar 1, 2022
•
edited
Loading
edited
- This PR resolve the issues reported by repo-linter for OSS policies
- I also made markdown linter fixes
- this also adds a release.yml file
Gatsby Cloud Build Reportinstant-observability-website 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 27s PerformanceLighthouse report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I don't think we need the generate-changelog
job unless that's also required
.github/workflows/release.yml
Outdated
- name: Re-enable "required_pull_request_reviews" branch protection | ||
id: enable-branch-protection | ||
if: always() | ||
uses: actions/github-script@v1 | ||
with: | ||
github-token: ${{ secrets.OPENSOURCE_BOT_TOKEN }} | ||
previews: luke-cage-preview | ||
script: | | ||
const result = await github.repos.updateBranchProtection({ | ||
owner: context.repo.owner, | ||
repo: context.repo.repo, | ||
branch: 'main', | ||
required_status_checks: null, | ||
restrictions: null, | ||
enforce_admins: true, | ||
required_pull_request_reviews: { | ||
dismiss_stale_reviews: true, | ||
required_approving_review_count: 1 | ||
} | ||
}) | ||
console.log("Result:", result) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- name: Re-enable "required_pull_request_reviews" branch protection | |
id: enable-branch-protection | |
if: always() | |
uses: actions/github-script@v1 | |
with: | |
github-token: ${{ secrets.OPENSOURCE_BOT_TOKEN }} | |
previews: luke-cage-preview | |
script: | | |
const result = await github.repos.updateBranchProtection({ | |
owner: context.repo.owner, | |
repo: context.repo.repo, | |
branch: 'main', | |
required_status_checks: null, | |
restrictions: null, | |
enforce_admins: true, | |
required_pull_request_reviews: { | |
dismiss_stale_reviews: true, | |
required_approving_review_count: 1 | |
} | |
}) | |
console.log("Result:", result) | |
- name: Re-enable "required_pull_request_reviews" branch protection | |
id: enable-branch-protection | |
if: always() | |
uses: actions/github-script@v1 | |
with: | |
github-token: ${{ secrets.OPENSOURCE_BOT_TOKEN }} | |
previews: luke-cage-preview | |
script: | | |
const result = await github.repos.updateBranchProtection({ | |
owner: context.repo.owner, | |
repo: context.repo.repo, | |
branch: 'main', | |
required_status_checks: null, | |
restrictions: null, | |
enforce_admins: true, | |
required_pull_request_reviews: { | |
dismiss_stale_reviews: true, | |
required_approving_review_count: 1 | |
} | |
}) | |
console.log("Result:", result) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aswanson-nr is this any different? I'm seeing this error when trying to commit
Suggestion cannot be identical to original text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me take a look
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed on the changelog! Just need a few changes to the branch protection
Not sure what happened with those comments, but this is what needs to be added to the "re-enable branch protection" step
|
@aswanson-nr I made the suggested change, let me know what you think. Thanks for the input here! |
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |