-
-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix "-split" option issues on sct_image #1627
Conversation
@fperdigon are you intending to merge into master or into Your branch was developed from another baseline branch ( This should work with: git fetch
git rebase --onto origin/master origin/poq_issue_1507_progress fperdigon_issue1556
git push origin fperdigon_issue1556 --force Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just making sure that we won't make this before knowing the intent.
@fperdigon why did you close this PR? |
sorry, my mistake |
as discussed in SCT meeting @fperdigon please:
|
142a2f0
to
81c71b3
Compare
Hollo @zougloub please a little help here. I ran the commands you told me and now a lot of commits that are not mine appear |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You did the right thing : only one commit from the master base. Only github wasn't aware of that yet. I changed the base and now github is happy too.
Yes, sure it was github web interface issue, now everything looks good, thanks @zougloub |
Description of the Change
With the option "-split" the code of line 274 must be executed.
The error was due to a failure in the flow control that executed the code of line 262.
Fixes #1556