Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes case if data image, segmentation and labels are not in the same space #1292

Merged
merged 4 commits into from
Apr 25, 2017

Conversation

jcohenadad
Copy link
Member

@jcohenadad jcohenadad commented Apr 25, 2017

Fixes #1168.
Fixed by removing the check.
In the future, we need to check if registration works if images have different matrix. If not, then we need to check for it.

@jcohenadad jcohenadad added bug category: fixes an error in the code fix:minor sct_register_to_template context: labels Apr 25, 2017
@jcohenadad jcohenadad added this to the Release 3.0.3 milestone Apr 25, 2017
@@ -257,6 +258,16 @@ def main():
# go to tmp folder
os.chdir(path_tmp)

# copy header of anat to segmentation (issue #1168)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this commented code still required?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes-- in case of future issue

Copy link
Contributor

@peristeri peristeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commenting out the code seams harmless. But this is a partial fix to issue #1168

@jcohenadad jcohenadad merged commit 46b8e07 into master Apr 25, 2017
@jcohenadad jcohenadad deleted the jca-1168 branch April 25, 2017 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug category: fixes an error in the code sct_register_to_template context:
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants