-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] partially validate local node JSON config #43
Conversation
Pull Request Test Coverage Report for Build 7213419581Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool use of jsonschema validation here @surchs!
Left a few 🍒 for your consideration; otherwise good to go!
Co-authored-by: Alyssa Dai <alyssa.ydai@gmail.com>
Co-authored-by: Alyssa Dai <alyssa.ydai@gmail.com>
Co-authored-by: Alyssa Dai <alyssa.ydai@gmail.com>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
mainly to check locally pre-commit because I didn't have it installed
No longer can I get away without having pre-commit installed. A good day.
local_nb_nodes.json
aren't valid #31Changes proposed in this pull request:
Checklist
[ENH]
,[FIX]
,[REF]
,[TST]
,[CI]
,[MNT]
,[INF]
,[MODEL]
,[DOC]
) (see https://neurobagel.org/contributing/pull_requests for more info)Closes #XXXX
For new features:
For bug fixes: