Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ultralytics/yolov5 integration #73

Merged
merged 6 commits into from
Feb 24, 2021
Merged

ultralytics/yolov5 integration #73

merged 6 commits into from
Feb 24, 2021

Conversation

bfineran
Copy link
Contributor

No description provided.

@bfineran bfineran requested a review from a team February 14, 2021 00:09
@bfineran bfineran self-assigned this Feb 14, 2021
@bfineran
Copy link
Contributor Author

this first commit includes requirements for running recipes within the yolov5 training script as well as a SparseZoo integration for recipes and checkpoint files. testing is WIP and is blocked by other resource priorities

mgoin
mgoin previously approved these changes Feb 14, 2021
View reviewed changes
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, docs and integration looks really clean to me. accepting now assuming that we'll have testing added in later work

examples/ultralytics-sparseml/README.md Outdated Show resolved Hide resolved
examples/ultralytics-sparseml/README.md Outdated Show resolved Hide resolved
markurtz
markurtz requested changes Feb 17, 2021
View reviewed changes
Copy link
Member

@markurtz markurtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same overall comments as the rwightman integration:

  • migrate it over to your suggestion of having a folder for integrations
  • name the root just ultralytics since we're already in the sparseml repo
  • remove path from the arg since this supports both paths and stubs for sparseml-recipe-path
  • change out functionality for sparse-transfer-learn to be more generic for sparsezoo-recipe-type
  • issues with using min_epoch from manager
  • logging for when we're overriding something such as with the number of epochs

examples/ultralytics-sparseml/README.md Outdated Show resolved Hide resolved
examples/ultralytics-sparseml/main.py Outdated Show resolved Hide resolved
@markurtz
Copy link
Member

Oh also, can we get the exact checkpoint of the integrated repo this was tested with in the even people have issues with newer versions?

@bfineran
Copy link
Contributor Author

Thanks for review @markurtz @mgoin should be up to date with reviews now

mgoin
mgoin previously approved these changes Feb 23, 2021
View reviewed changes
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

markurtz
markurtz requested changes Feb 23, 2021
View reviewed changes
integrations/ultralytics/README.md Outdated Show resolved Hide resolved
markurtz
markurtz previously approved these changes Feb 23, 2021
View reviewed changes
@markurtz markurtz requested a review from a team February 23, 2021 15:22
mgoin
mgoin previously approved these changes Feb 23, 2021
View reviewed changes
@bfineran bfineran dismissed stale reviews from mgoin and markurtz via 43cdcf5 February 23, 2021 20:44
@bfineran bfineran force-pushed the ultralytics-integration branch 3 times, most recently from a238876 to e60d716 Compare February 23, 2021 22:54
markurtz
markurtz previously approved these changes Feb 23, 2021
View reviewed changes
jeanniefinks
jeanniefinks previously approved these changes Feb 23, 2021
View reviewed changes
Copy link
Member

@jeanniefinks jeanniefinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor typo fix from me per last comment and you are gtg from me.

mgoin
mgoin previously approved these changes Feb 23, 2021
View reviewed changes
@bfineran bfineran merged commit 7abf9e4 into main Feb 24, 2021
@bfineran bfineran deleted the ultralytics-integration branch February 24, 2021 18:11
markurtz added a commit that referenced this pull request Feb 25, 2021
@markurtz @jeanniefinks
@bfineran @eldarkurtic @natuan
Rebase release/0.1 off of main for 0.1.1 (#87)
edcce80 
* GA code, toctree links (#61)

- added tracking for docs output
- added help links for docs output

* Update README.md (#64)

removed placeholder reference to comingsoon repo in favor of active repo

* add decorator for flaky tf sparsity tests (#65)

* enable modifier groups in SparseML recipes (#66)

* enable modifier groups in SparseML recipes
* unit tests for YAML modifier list loading

* make build argument for nightly builds (#63)

* rst url syntax correction (#67)

correcting double slash at the end of URLs with updates to index.rst pre-compilation

* match types explicitly in torch qat quant observer wrappers (#68)

* docs updates (#71)

enhancing left nav for Help; after this merge, the docs need to be rebuilt for this repo so docs.neuralmagic.com can be refreshed. cc @markurtz

* Rename KSModifier to PruningModifier (#76)

* Rename ConstantKSModifier to ConstantPruningModifier

* Rename GradualKSModifier to GMPruningModifier

* Fix broken link for Optimization Recipes (#75)

* Serialize/deserialize MaskedLayer (#69)

* Serialize/deserialize MaskedLayer

* Remove unused symbols

* Register pruning scheduler classes for serialization

* removed ScheduledOptimizer, moved logic to ScheduledModifierManager (#77)

* load recipes directly from SparseZoo (#72)

* load recipes into Managers from sparsezoo stubs
* moving recipe_type handling to SparseZoo only, supporting loading SparseZoo recipe objects

* Revert "removed ScheduledOptimizer, moved logic to ScheduledModifierManager (#77)" (#80)

This reverts commit 6073abb.

* Update for 0.1.1 release (#82)

* Update for 0.1.1 release
- update python version to 0.1.1
- setup.py add in version parts and _VERSION_MAJOR_MINOR for more flexibility with dependencies between neural magic packages
- add in deepsparse optional install pathway

* missed updating version to 0.1.1

* rename examples directory to integrations (#78)

* rwightman/pytorch-image-models integration (#70)

* load checkpoint file based on sparsezoo recipe in pytorch_vision script (#83)

* ultralytics/yolov5 integration (#73)

* pytorch sparse quantized transfer learning notebook (#81)

* load qat onnx models for conversion from file path (#86)

* Sparsification update (#84)

* Sparsification update
- update sparsification descriptions and move to preferred verbage

* update from comments on deepsparse for sparsification

* Update README.md

Co-authored-by: Jeannie Finks <74554921+jeanniefinks@users.noreply.github.com>

* Update README.md

Co-authored-by: Jeannie Finks <74554921+jeanniefinks@users.noreply.github.com>

* Update README.md

Co-authored-by: Jeannie Finks <74554921+jeanniefinks@users.noreply.github.com>

* Update README.md

Co-authored-by: Jeannie Finks <74554921+jeanniefinks@users.noreply.github.com>

* Update docs/source/index.rst

Co-authored-by: Jeannie Finks <74554921+jeanniefinks@users.noreply.github.com>

* Update docs/source/index.rst

Co-authored-by: Jeannie Finks <74554921+jeanniefinks@users.noreply.github.com>

* Update docs/source/index.rst

Co-authored-by: Jeannie Finks <74554921+jeanniefinks@users.noreply.github.com>

* Update docs/source/index.rst

Co-authored-by: Jeannie Finks <74554921+jeanniefinks@users.noreply.github.com>

* Update docs/source/recipes.md

Co-authored-by: Jeannie Finks <74554921+jeanniefinks@users.noreply.github.com>

* fix links in index.rst from reviewed content

* update overviews and taglines from doc

Co-authored-by: Jeannie Finks <74554921+jeanniefinks@users.noreply.github.com>

* blog style readme for torch sparse-quant TL notebook (#85)

Co-authored-by: Jeannie Finks (NM) <74554921+jeanniefinks@users.noreply.github.com>
Co-authored-by: Benjamin Fineran <bfineran@users.noreply.github.com>
Co-authored-by: Eldar Kurtic <eldar.ciki@gmail.com>
Co-authored-by: Tuan Nguyen <tuan@neuralmagic.com>
markurtz added a commit that referenced this pull request Sep 1, 2021
@markurtz
yolov5 model page (#73)
b36eda6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeanniefinks jeanniefinks jeanniefinks left review comments

@mgoin mgoin mgoin approved these changes

@markurtz markurtz markurtz approved these changes

Assignees

@bfineran bfineran

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bfineran @markurtz @mgoin @jeanniefinks