Refactor of Transformers SparseML CLI and integrations #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markurtz
requested review from
mgoin,
rahul-tuli and
KSGulin
and removed request for
a team
rahul-tuli
requested changes
Jan 31, 2022
rahul-tuli
reviewed
Jan 31, 2022
rahul-tuli
reviewed
Jan 31, 2022
Co-authored-by: Rahul Tuli <rahul@neuralmagic.com>
Co-authored-by: Rahul Tuli <rahul@neuralmagic.com>
bfineran
reviewed
Jan 31, 2022
natuan
suggested changes
Feb 1, 2022
markurtz
commented
Feb 1, 2022
natuan
reviewed
Feb 1, 2022
… for transformers trainer
bfineran
reviewed
Feb 1, 2022
src/sparseml/transformers/export.py
Outdated
|
|
||
| # create fake model input | ||
| inputs = tokenizer( | ||
| "", return_tensors="pt", padding=PaddingStrategy.MAX_LENGTH.value | ||
| ).data # Dict[Tensor] | ||
| _LOGGER.info(f"Created sample inputs for the ONNX export process: {inputs}") |
There was a problem hiding this comment.
the inputs here are coming from a tokenized/padded empty string and will be just a large tensor of mostly 0s, ends up being more like log spam. could print out input shapes or names instead
bfineran
previously approved these changes
Feb 1, 2022
rahul-tuli
previously approved these changes
Feb 1, 2022
bfineran
approved these changes
Feb 1, 2022
natuan
approved these changes
Feb 1, 2022
rahul-tuli
approved these changes
Feb 1, 2022
bfineran
pushed a commit
that referenced
this pull request
Feb 2, 2022
* Refactor of Transformers SparseML CLI and integrations * Refactor export.py to use new pathways, fix make quality * Update src/sparseml/optim/manager.py Co-authored-by: Rahul Tuli <rahul@neuralmagic.com> * Update src/sparseml/transformers/utils/model.py Co-authored-by: Rahul Tuli <rahul@neuralmagic.com> * fixes from review * fixes from review and testing * bug fixes and logging * bug fixes for export and distillation * review fixes, quality fixes, style fixes * fix dependency issue * fix distillation tests * fix distillation tests * fix distillation tests * fill in docs and update style * fix issue with distillation improperly updating students inputs * fix quality * Update src/sparseml/pytorch/optim/modifier_distillation.py * add in better logging for missing and unexpected keys in model reload for transformers trainer * fix logging for transformers export Co-authored-by: Rahul Tuli <rahul@neuralmagic.com>
markurtz
added a commit
that referenced
this pull request
Feb 2, 2022
* Refactor of Transformers SparseML CLI and integrations (#536) * Refactor of Transformers SparseML CLI and integrations * Refactor export.py to use new pathways, fix make quality * Update src/sparseml/optim/manager.py Co-authored-by: Rahul Tuli <rahul@neuralmagic.com> * Update src/sparseml/transformers/utils/model.py Co-authored-by: Rahul Tuli <rahul@neuralmagic.com> * fixes from review * fixes from review and testing * bug fixes and logging * bug fixes for export and distillation * review fixes, quality fixes, style fixes * fix dependency issue * fix distillation tests * fix distillation tests * fix distillation tests * fill in docs and update style * fix issue with distillation improperly updating students inputs * fix quality * Update src/sparseml/pytorch/optim/modifier_distillation.py * add in better logging for missing and unexpected keys in model reload for transformers trainer * fix logging for transformers export Co-authored-by: Rahul Tuli <rahul@neuralmagic.com> * Fix model load bug and add logging to catch potential future issues (#537) * Fix model load bug and add logging to catch potential future issues * initial migration to generalize module sparsification information * propagate ModuleSparsificationInfo * report type of input tensors in export.py * minor bug fixes * ModuleSparsificationInfo docs * export onnx bugfix * bug fixes * make style * bug fix for quantization * revert to use ScheduledOptimizer due to bug with torch LambdaLR * remove language_modeling script * add end model sparsification log Co-authored-by: Benjamin <ben@neuralmagic.com> Co-authored-by: Mark Kurtz <mark@neuralmagic.com> Co-authored-by: Rahul Tuli <rahul@neuralmagic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.