Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Small fixes to account for changes to RegistryMixin #1558

Merged
merged 6 commits into from
Jan 23, 2024

Conversation

dbogunowicz
Copy link
Contributor

In this PR: neuralmagic/sparsezoo#404 I added minor improvements to the RegistryMixin that we need to account for (they are breaking some of the tests in the GHA).
To be cherry-picked to 1.7 once it lands to main

rahul-tuli
rahul-tuli previously approved these changes Jan 23, 2024
@rahul-tuli
Copy link
Member

LGTM!

bfineran
bfineran previously approved these changes Jan 23, 2024
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm once remaining tests are fixed

@dbogunowicz dbogunowicz dismissed stale reviews from bfineran and rahul-tuli via ad46fb6 January 23, 2024 19:24
bfineran
bfineran previously approved these changes Jan 23, 2024
@mgoin mgoin merged commit 0552dbe into main Jan 23, 2024
13 checks passed
@mgoin mgoin deleted the fix/damian/adapt_to_digest_aliases branch January 23, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants