Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service worker prevents function calls #2

Closed
lgraubner opened this issue Mar 21, 2018 · 4 comments
Closed

Service worker prevents function calls #2

lgraubner opened this issue Mar 21, 2018 · 4 comments

Comments

@lgraubner
Copy link
Contributor

As the service worker seems to be the "official" one I assume it can't be used like this in combination with functions.

facebook/create-react-app#2237 (comment)

The Service worker will just return the app instead of the function itself. Only option is ejecting and extend navigateFallbackWhitelist option.

I didn't test this with this package, but with a bare CRA app and functions which should be basically the same.

Derrick83 pushed a commit to Derrick83/LearnLive that referenced this issue Mar 25, 2018
@swyxio
Copy link
Contributor

swyxio commented Oct 17, 2018

Hi Lars, sorry for the super super late response. i just joined the team.

Its been a long while so I'm gonna assume this is stale. but if you still need this looked at please feel free to reopen!

@swyxio swyxio closed this as completed Oct 17, 2018
@lgraubner
Copy link
Contributor Author

Hi Shawn, thanks for your response.

I think this is still relevant as this boilerplate will not work like this. Please correct me if I'm wrong. :)

Only solution for me was to eject and adjust the webpack config.

@swyxio
Copy link
Contributor

swyxio commented Oct 17, 2018

i mean for what its worth the service worker is off by default in CRA v2. i never use it.

@lgraubner
Copy link
Contributor Author

This wasn't the case for v1. :) I'd suggest adding a note to the README to prevent other people from running into the same problem. I'm willing to create a PR if you like.

lgraubner added a commit to lgraubner/create-react-app-lambda that referenced this issue Oct 20, 2018
swyxio added a commit that referenced this issue Oct 22, 2018
Add note about service worker usage #2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants