Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaces npm with yarn #1

Merged
merged 2 commits into from
Sep 11, 2017
Merged

Replaces npm with yarn #1

merged 2 commits into from
Sep 11, 2017

Conversation

gijsstegehuis
Copy link

No description provided.

@boboldehampsink
Copy link

Doesn't yarn need a yarn.lock file?

@gijsstegehuis
Copy link
Author

not necessarily + you would need to add yarn.lock to a .slugignore file in your project.
see: heroku/heroku-buildpack-nodejs#337 (comment)

@boboldehampsink
Copy link

Can't you check if there's a yarn.lock file, then execute yarn - else execute npm?

@gijsstegehuis
Copy link
Author

Fixed in 272d93d

@gijsstegehuis gijsstegehuis merged commit 1eb45ed into master Sep 11, 2017
@gijsstegehuis gijsstegehuis deleted the feature/yarn branch September 11, 2017 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boboldehampsink boboldehampsink boboldehampsink approved these changes

@nschmoller nschmoller Awaiting requested review from nschmoller

@svercammen svercammen Awaiting requested review from svercammen

@bvangennep bvangennep Awaiting requested review from bvangennep

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gijsstegehuis @boboldehampsink