-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove pillow from dependencies #1745
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1745 +/- ##
==========================================
- Coverage 75.32% 74.94% -0.38%
==========================================
Files 244 244
Lines 13036 13036
==========================================
- Hits 9819 9770 -49
- Misses 3217 3266 +49
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whats the reason for getting rid of PIL importskip
in favor of dynamic import
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
importskip
seems to work only in test files that are not imported later on. Here's a utils
file that's not directly tested. The result of using importskip
here was an error:
https://github.com/neptune-ai/neptune-client/actions/runs/8717801814/job/23914764348
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more important thing. Shouldn't Pillow
be now added to dev_requirements.txt
so tests that use Pillow
are not skipped?
Before submitting checklist