Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pillow from dependencies #1745

Merged
merged 7 commits into from
Apr 17, 2024
Merged

Remove pillow from dependencies #1745

merged 7 commits into from
Apr 17, 2024

Conversation

AleksanderWWW
Copy link
Contributor

@AleksanderWWW AleksanderWWW commented Apr 16, 2024

Before submitting checklist

  • Did you update the CHANGELOG? (not for test updates, internal changes/refactors or CI/CD setup)
  • Did you ask the docs owner to review all the user-facing changes?

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.94%. Comparing base (1de1f64) to head (39d4bb7).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1745      +/-   ##
==========================================
- Coverage   75.32%   74.94%   -0.38%     
==========================================
  Files         244      244              
  Lines       13036    13036              
==========================================
- Hits         9819     9770      -49     
- Misses       3217     3266      +49     
Flag Coverage Δ
e2e 61.98% <100.00%> (ø)
e2e-management 55.72% <0.00%> (-0.03%) ⬇️
e2e-s3 52.91% <0.00%> (-0.01%) ⬇️
e2e-s3-gcs 52.91% <0.00%> (-0.01%) ⬇️
e2e-standard 61.97% <100.00%> (ø)
macos 61.92% <100.00%> (-13.34%) ⬇️
py3.10 ?
py3.11 ?
py3.12 62.50% <100.00%> (-13.42%) ⬇️
py3.7 74.38% <100.00%> (-0.26%) ⬇️
py3.7.16 61.14% <100.00%> (-13.43%) ⬇️
py3.8 ?
py3.9 ?
ubuntu 74.89% <100.00%> (-0.38%) ⬇️
unit 71.89% <100.00%> (-1.14%) ⬇️
windows 73.51% <100.00%> (-0.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AleksanderWWW
Copy link
Contributor Author

AleksanderWWW commented Apr 17, 2024

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whats the reason for getting rid of PIL importskip in favor of dynamic import

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

importskip seems to work only in test files that are not imported later on. Here's a utils file that's not directly tested. The result of using importskip here was an error:
https://github.com/neptune-ai/neptune-client/actions/runs/8717801814/job/23914764348

Copy link
Contributor

@szysad szysad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more important thing. Shouldn't Pillow be now added to dev_requirements.txt so tests that use Pillow are not skipped?

@AleksanderWWW AleksanderWWW merged commit 352b1ad into master Apr 17, 2024
29 checks passed
@AleksanderWWW AleksanderWWW deleted the aw/remove-pillow branch April 17, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants