Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworked series values models and protocol buffers added #1738

Merged
merged 4 commits into from
Apr 16, 2024

Conversation

Raalsky
Copy link
Contributor

@Raalsky Raalsky commented Apr 12, 2024

Before submitting checklist

  • Did you update the CHANGELOG? (not for test updates, internal changes/refactors or CI/CD setup)
  • Did you ask the docs owner to review all the user-facing changes?

Copy link

codecov bot commented Apr 12, 2024

Codecov Report

Attention: Patch coverage is 85.13514% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 73.11%. Comparing base (f5e087c) to head (59d4069).

Files Patch % Lines
...pi/proto/neptune_pb/api/model/series_values_pb2.py 64.70% 6 Missing ⚠️
...eptune/internal/backends/hosted_neptune_backend.py 0.00% 3 Missing ⚠️
src/neptune/api/models.py 97.82% 1 Missing ⚠️
src/neptune/attributes/series/fetchable_series.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1738      +/-   ##
==========================================
- Coverage   76.81%   73.11%   -3.71%     
==========================================
  Files         243      244       +1     
  Lines       12955    12812     -143     
==========================================
- Hits         9952     9368     -584     
- Misses       3003     3444     +441     
Flag Coverage Δ
e2e ?
e2e-management ?
e2e-s3 ?
e2e-s3-gcs ?
e2e-standard ?
py3.10 ?
py3.11 ?
py3.12 ?
py3.7 73.11% <85.13%> (-3.08%) ⬇️
py3.8 ?
py3.9 ?
ubuntu 73.07% <85.13%> (-3.69%) ⬇️
unit 73.11% <85.13%> (-0.64%) ⬇️
windows 72.01% <85.13%> (-4.44%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Raalsky
Copy link
Contributor Author

Raalsky commented Apr 12, 2024

szysad
szysad previously approved these changes Apr 16, 2024
Copy link
Contributor

@szysad szysad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Raalsky Raalsky merged commit b6a168f into master Apr 16, 2024
4 checks passed
@Raalsky Raalsky deleted the rj/proto-series-values branch April 16, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants