Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fields DTO conversion reworked #1722

Merged
merged 22 commits into from
Apr 8, 2024
Merged

Fields DTO conversion reworked #1722

merged 22 commits into from
Apr 8, 2024

Conversation

Raalsky
Copy link
Contributor

@Raalsky Raalsky commented Apr 5, 2024

As we're going to add support for protocol buffers when fetching data we had to add a proper API level and DTOs conversion. Previously we've been using Bravado models directly/JSONs.

Before submitting checklist

  • Did you update the CHANGELOG? (not for test updates, internal changes/refactors or CI/CD setup)
  • Did you ask the docs owner to review all the user-facing changes?

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 89.26316% with 51 lines in your changes are missing coverage. Please review.

Project coverage is 73.90%. Comparing base (45d38f0) to head (e80c971).
Report is 4 commits behind head on master.

Files Patch % Lines
src/neptune/api/models.py 92.27% 20 Missing ⚠️
...eptune/internal/backends/hosted_neptune_backend.py 41.66% 14 Missing ⚠️
src/neptune/integrations/pandas/__init__.py 87.75% 6 Missing ⚠️
.../neptune/internal/backends/neptune_backend_mock.py 87.23% 6 Missing ⚠️
src/neptune/api/field_visitor.py 88.88% 4 Missing ⚠️
src/neptune/table.py 95.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1722      +/-   ##
==========================================
- Coverage   77.84%   73.90%   -3.95%     
==========================================
  Files         240      242       +2     
  Lines       12534    12614      +80     
==========================================
- Hits         9757     9322     -435     
- Misses       2777     3292     +515     
Flag Coverage Δ
e2e ?
e2e- ?
e2e-management ?
e2e-s3 ?
e2e-s3-gcs ?
e2e-standard ?
macos 73.81% <89.26%> (-3.95%) ⬇️
py3.10 ?
py3.11 ?
py3.12 ?
py3.7 73.87% <89.26%> (-3.51%) ⬇️
py3.7.16 ?
py3.8 ?
py3.9 ?
ubuntu 73.74% <89.26%> (-4.03%) ⬇️
ubuntu-latest ?
unit 73.87% <89.26%> (-0.13%) ⬇️
windows 72.74% <89.26%> (-4.66%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Raalsky Raalsky changed the title Draft: Field conversion reworked Field conversion reworked Apr 5, 2024
@Raalsky Raalsky changed the title Field conversion reworked Fields DTO conversion reworked Apr 5, 2024
@Raalsky
Copy link
Contributor Author

Raalsky commented Apr 5, 2024

szysad
szysad previously approved these changes Apr 8, 2024
Copy link
Contributor

@szysad szysad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀

src/neptune/api/models.py Show resolved Hide resolved
src/neptune/api/models.py Show resolved Hide resolved
src/neptune/api/models.py Show resolved Hide resolved
src/neptune/internal/backends/hosted_neptune_backend.py Outdated Show resolved Hide resolved
tests/unit/neptune/new/api/test_models.py Show resolved Hide resolved
Copy link
Contributor

@szysad szysad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀🚀🚀

@Raalsky Raalsky merged commit f9da5f2 into master Apr 8, 2024
4 checks passed
@Raalsky Raalsky deleted the rj/rework-types branch April 8, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants