-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fields DTO conversion reworked #1722
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1722 +/- ##
==========================================
- Coverage 77.84% 73.90% -3.95%
==========================================
Files 240 242 +2
Lines 12534 12614 +80
==========================================
- Hits 9757 9322 -435
- Misses 2777 3292 +515
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀🚀🚀
As we're going to add support for protocol buffers when fetching data we had to add a proper API level and DTOs conversion. Previously we've been using Bravado models directly/JSONs.
Before submitting checklist