Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove neptune-client #1699

Merged
merged 4 commits into from
Mar 19, 2024
Merged

Remove neptune-client #1699

merged 4 commits into from
Mar 19, 2024

Conversation

AleksanderWWW
Copy link
Contributor

@AleksanderWWW AleksanderWWW commented Mar 18, 2024

Before submitting checklist

  • Did you update the CHANGELOG? (not for test updates, internal changes/refactors or CI/CD setup)
  • Did you ask the docs owner to review all the user-facing changes?

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 74.10%. Comparing base (cf086c8) to head (e86028a).

Files Patch % Lines
src/neptune/internal/backends/hosted_client.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           dev/2.0    #1699   +/-   ##
========================================
  Coverage    74.10%   74.10%           
========================================
  Files          336      336           
  Lines        16484    16477    -7     
========================================
- Hits         12215    12210    -5     
+ Misses        4269     4267    -2     
Flag Coverage Δ
macos 76.97% <85.71%> (+<0.01%) ⬆️
py3.7 77.19% <85.71%> (+<0.01%) ⬆️
ubuntu 77.01% <85.71%> (-0.06%) ⬇️
unit 77.19% <85.71%> (+<0.01%) ⬆️
windows 75.71% <85.71%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@szysad szysad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

btw I think @normandy7 should take a look at docs

src/neptune/internal/utils/logger.py Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@AleksanderWWW AleksanderWWW merged commit 9785399 into dev/2.0 Mar 19, 2024
4 checks passed
@AleksanderWWW AleksanderWWW deleted the aw/neptune-client branch March 19, 2024 09:01
Raalsky pushed a commit that referenced this pull request Mar 25, 2024
Co-authored-by: Sabine <sabine.nyholm@neptune.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants