Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor updates to made package compatible with Python 3.11 and 3.12 #1678

Merged
merged 7 commits into from
Mar 13, 2024

Conversation

Raalsky
Copy link
Contributor

@Raalsky Raalsky commented Mar 7, 2024

Before submitting checklist

  • Did you update the CHANGELOG? (not for test updates, internal changes/refactors or CI/CD setup)
  • Did you ask the docs owner to review all the user-facing changes?

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 88.37209% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 74.92%. Comparing base (dc1d69b) to head (ef2f4ef).

Files Patch % Lines
src/neptune/core/components/abstract.py 0.00% 4 Missing ⚠️
src/neptune/legacy/experiments.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1678      +/-   ##
==========================================
- Coverage   80.86%   74.92%   -5.94%     
==========================================
  Files         304      304              
  Lines       15503    15176     -327     
==========================================
- Hits        12536    11371    -1165     
- Misses       2967     3805     +838     
Flag Coverage Δ
e2e ?
e2e-management ?
e2e-s3 ?
e2e-s3-gcs ?
e2e-standard ?
macos 74.71% <88.37%> (-5.95%) ⬇️
py3.10 ?
py3.7 74.54% <88.37%> (-5.71%) ⬇️
py3.7.16 ?
py3.8 ?
py3.9 ?
ubuntu 74.41% <88.37%> (-5.89%) ⬇️
unit 74.54% <88.37%> (-0.91%) ⬇️
windows 73.91% <88.37%> (-6.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Raalsky Raalsky changed the title Python versions testing matrix extended Minor updates to made package compatible with Python 3.11 and 3.12 Mar 10, 2024
@Raalsky
Copy link
Contributor Author

Raalsky commented Mar 10, 2024

Copy link
Contributor

@szysad szysad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big part of this PR is syntax change from

def f():
    ...

to

def f(): ...

Can you just explain a bit why is this necessary?

Besides that looks solid 🪨🤘

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we getting rid of python3.10 tests here?
If yes are we sure we want to do that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We used to test with the latest supported and the oldest one. So it still remains by testing Python 3.12 instead.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is going on here haha?
I have read a bit about Ellipsis but cant find any info about this stuff

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just black :P. You can check commit by commit as there is one about black suggestions.

@Raalsky
Copy link
Contributor Author

Raalsky commented Mar 13, 2024

Can you just explain a big how why is this necessary?

It was just black formatting applied 😉. Not sure why they changed that.

@Raalsky Raalsky merged commit 46ae5eb into master Mar 13, 2024
4 checks passed
@Raalsky Raalsky deleted the rj/py-311-312 branch March 13, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants