-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor updates to made package compatible with Python 3.11 and 3.12 #1678
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1678 +/- ##
==========================================
- Coverage 80.86% 74.92% -5.94%
==========================================
Files 304 304
Lines 15503 15176 -327
==========================================
- Hits 12536 11371 -1165
- Misses 2967 3805 +838
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big part of this PR is syntax change from
def f():
...
to
def f(): ...
Can you just explain a bit why is this necessary?
Besides that looks solid 🪨🤘
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we getting rid of python3.10 tests here?
If yes are we sure we want to do that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We used to test with the latest supported and the oldest one. So it still remains by testing Python 3.12 instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is going on here haha?
I have read a bit about Ellipsis
but cant find any info about this stuff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just black
:P. You can check commit by commit as there is one about black
suggestions.
It was just |
Before submitting checklist