Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce querying capabilities to fetch_models_table #1677

Merged
merged 8 commits into from
Mar 12, 2024

Conversation

szysad
Copy link
Contributor

@szysad szysad commented Mar 6, 2024

Before submitting checklist

  • Did you update the CHANGELOG? (not for test updates, internal changes/refactors or CI/CD setup)
  • Did you ask the docs owner to review all the user-facing changes?

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.84%. Comparing base (c64dbf4) to head (a26c01d).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1677      +/-   ##
==========================================
- Coverage   80.96%   80.84%   -0.12%     
==========================================
  Files         304      304              
  Lines       15495    15497       +2     
==========================================
- Hits        12545    12529      -16     
- Misses       2950     2968      +18     
Flag Coverage Δ
e2e 72.21% <100.00%> (-0.34%) ⬇️
e2e- ?
e2e-management 56.92% <100.00%> (+0.38%) ⬆️
e2e-s3 55.62% <0.00%> (-0.32%) ⬇️
e2e-s3-gcs 55.93% <0.00%> (+0.30%) ⬆️
e2e-standard 72.03% <100.00%> (-0.10%) ⬇️
macos 80.42% <100.00%> (-0.25%) ⬇️
macos-latest ?
py3.10 71.77% <100.00%> (-9.06%) ⬇️
py3.11 ?
py3.7 80.27% <100.00%> (+0.24%) ⬆️
py3.7.16 71.24% <100.00%> (-8.93%) ⬇️
py3.8 ?
py3.9 ?
ubuntu 80.57% <100.00%> (-0.16%) ⬇️
ubuntu-latest ?
unit 74.94% <100.00%> (-0.47%) ⬇️
windows 79.92% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@szysad
Copy link
Contributor Author

szysad commented Mar 6, 2024

@szysad szysad marked this pull request as ready for review March 6, 2024 16:09
@Raalsky
Copy link
Contributor

Raalsky commented Mar 7, 2024

@szysad szysad merged commit dc1d69b into master Mar 12, 2024
28 of 29 checks passed
@szysad szysad deleted the ss/query-models-table branch March 12, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants