Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Postgres 16 default version #8745

Merged
merged 4 commits into from
Aug 20, 2024
Merged

Conversation

bayandin
Copy link
Member

@bayandin bayandin commented Aug 16, 2024

Problem

The default Postgres version is set to 15 in code, while we use 16 in most of the other places (and Postgres 17 is coming)

Summary of changes

  • Run benchmarks job with Postgres 16 (instead of Postgres 14)
  • Set DEFAULT_PG_VERSION to 16 in all places
  • Remove deprecated --pg-version pytest argument
  • Update test_metadata_bincode_serde_ensure_roundtrip for Postgres 16

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@bayandin bayandin added the run-benchmarks Indicates to the CI that benchmarks should be run for PR marked with this label label Aug 16, 2024
Copy link

github-actions bot commented Aug 16, 2024

2252 tests run: 2178 passed, 0 failed, 74 skipped (full report)


Flaky tests (1)

Postgres 16

  • test_layer_bloating: debug

Code coverage* (full report)

  • functions: 32.4% (7222 of 22268 functions)
  • lines: 50.4% (58312 of 115744 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
211c7b2 at 2024-08-16T12:40:04.582Z :recycle:

@bayandin bayandin force-pushed the bayandin/default-postgres-16 branch from 361beb7 to 617a661 Compare August 16, 2024 09:31
@bayandin bayandin marked this pull request as ready for review August 16, 2024 16:28
@bayandin bayandin requested a review from a team as a code owner August 16, 2024 16:28
@bayandin bayandin merged commit c96593b into main Aug 20, 2024
71 checks passed
@bayandin bayandin deleted the bayandin/default-postgres-16 branch August 20, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-benchmarks Indicates to the CI that benchmarks should be run for PR marked with this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants