Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(pageserver): add test_gc_feedback_with_snapshots #8474

Merged
merged 5 commits into from
Jul 31, 2024

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Jul 23, 2024

Problem

should be working after #8328 gets merged. Part of #8002

Summary of changes

adds a new perf benchmark case that ensures garbages can be collected with branches

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@skyzh skyzh added the run-benchmarks Indicates to the CI that benchmarks should be run for PR marked with this label label Jul 23, 2024
Copy link

github-actions bot commented Jul 23, 2024

3150 tests run: 3029 passed, 0 failed, 121 skipped (full report)


Flaky tests (1)

Postgres 14

  • test_partial_evict_tenant[relative_spare]: release

Code coverage* (full report)

  • functions: 32.5% (7023 of 21597 functions)
  • lines: 49.9% (55895 of 111995 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
d06d6c3 at 2024-07-30T20:19:15.723Z :recycle:

@skyzh skyzh force-pushed the skyzh/test-gc-feedback-snapshot branch 2 times, most recently from 50412a2 to a7afdd1 Compare July 25, 2024 18:21
@skyzh skyzh marked this pull request as ready for review July 25, 2024 21:43
@skyzh skyzh requested a review from problame July 25, 2024 21:43
Signed-off-by: Alex Chi Z <chi@neon.tech>
Signed-off-by: Alex Chi Z <chi@neon.tech>
Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh force-pushed the skyzh/test-gc-feedback-snapshot branch from a7afdd1 to 7bcc1f9 Compare July 29, 2024 16:43
@skyzh
Copy link
Member Author

skyzh commented Jul 30, 2024

The benchmark is running in the benchmarks(3) job, while the original one is in benchmarks(2), seems that the CI job is very smart at splitting those things...

scripts/benchmark_durations.py Show resolved Hide resolved
test_runner/performance/test_gc_feedback.py Outdated Show resolved Hide resolved
test_runner/performance/test_gc_feedback.py Outdated Show resolved Hide resolved
Signed-off-by: Alex Chi Z <chi@neon.tech>
Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh merged commit d6c79b7 into main Jul 31, 2024
69 checks passed
@skyzh skyzh deleted the skyzh/test-gc-feedback-snapshot branch July 31, 2024 21:55
arpad-m pushed a commit that referenced this pull request Aug 5, 2024
should be working after #8328
gets merged. Part of #8002

adds a new perf benchmark case that ensures garbages can be collected
with branches

---------

Signed-off-by: Alex Chi Z <chi@neon.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-benchmarks Indicates to the CI that benchmarks should be run for PR marked with this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants