Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task_mgr::spawn: require a TenantId #8462

Merged
merged 3 commits into from
Aug 20, 2024
Merged

Conversation

problame
Copy link
Contributor

@problame problame commented Jul 22, 2024

… to dis-incentivize global tasks via task_mgr in the future

(As of #8339 all remaining task_mgr usage is tenant or timeline scoped.)

Copy link

github-actions bot commented Jul 22, 2024

2198 tests run: 2129 passed, 0 failed, 69 skipped (full report)


Flaky tests (1)

Postgres 16

  • test_timeline_detach_ancestor_interrupted_by_deletion[False-delete_timeline]: release

Code coverage* (full report)

  • functions: 32.4% (7231 of 22306 functions)
  • lines: 50.4% (58483 of 116096 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
2f22929 at 2024-08-20T08:35:04.943Z :recycle:

Base automatically changed from problame/slow-detach-fix to main July 31, 2024 15:05
@problame problame force-pushed the problame/task_mgr-require-tenant-id branch from 7ad8a27 to 7bae552 Compare August 12, 2024 08:25
@problame problame marked this pull request as ready for review August 13, 2024 07:53
@problame problame requested a review from a team as a code owner August 13, 2024 07:53
@problame problame requested review from skyzh and koivunej and removed request for skyzh August 13, 2024 07:53
Copy link
Member

@koivunej koivunej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this after merging #8706 but yeah this seems sensible.

Copy link
Member

@koivunej koivunej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whatever, I'll handle the conflict, I got some new more interesting test failures.

@problame
Copy link
Contributor Author

Test failure due to #8710

@problame problame enabled auto-merge (squash) August 19, 2024 14:28
@problame
Copy link
Contributor Author

Test flakiness #8766

@problame problame merged commit ef57e73 into main Aug 20, 2024
63 checks passed
@problame problame deleted the problame/task_mgr-require-tenant-id branch August 20, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants