-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
task_mgr::spawn: require a TenantId
#8462
Conversation
2198 tests run: 2129 passed, 0 failed, 69 skipped (full report)Flaky tests (1)Postgres 16
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
2f22929 at 2024-08-20T08:35:04.943Z :recycle: |
…ia task_mgr in the future
7ad8a27
to
7bae552
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge this after merging #8706 but yeah this seems sensible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whatever, I'll handle the conflict, I got some new more interesting test failures.
Test failure due to #8710 |
Test flakiness #8766 |
… to dis-incentivize global tasks via task_mgr in the future
(As of #8339 all remaining task_mgr usage is tenant or timeline scoped.)