Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pageserver): include aux file in basebackup only once #8207

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Jun 28, 2024

Problem

Extracted from #6560, currently we include multiple copies of aux files in the basebackup.

Summary of changes

Fix the loop.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@skyzh skyzh requested a review from a team as a code owner June 28, 2024 17:59
@skyzh skyzh requested review from VladLazar and knizhnik June 28, 2024 17:59
Co-Authored-By: Konstantin Knizhnik <knizhnik@neon.tech>
Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh force-pushed the skyzh/aux-basebackup-fix branch from 575900e to e50e6f5 Compare July 1, 2024 13:54
@skyzh skyzh enabled auto-merge (squash) July 1, 2024 14:33
@skyzh skyzh merged commit b02aafd into main Jul 1, 2024
53 checks passed
@skyzh skyzh deleted the skyzh/aux-basebackup-fix branch July 1, 2024 14:36
Copy link

github-actions bot commented Jul 1, 2024

3000 tests run: 2885 passed, 0 failed, 115 skipped (full report)


Code coverage* (full report)

  • functions: 32.7% (6913 of 21149 functions)
  • lines: 50.0% (54180 of 108321 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
e50e6f5 at 2024-07-01T14:45:51.866Z :recycle:

VladLazar pushed a commit that referenced this pull request Jul 8, 2024
Extracted from #6560, currently
we include multiple copies of aux files in the basebackup.

## Summary of changes

Fix the loop.

Signed-off-by: Alex Chi Z <chi@neon.tech>
Co-authored-by: Konstantin Knizhnik <knizhnik@neon.tech>
VladLazar pushed a commit that referenced this pull request Jul 8, 2024
Extracted from #6560, currently
we include multiple copies of aux files in the basebackup.

## Summary of changes

Fix the loop.

Signed-off-by: Alex Chi Z <chi@neon.tech>
Co-authored-by: Konstantin Knizhnik <knizhnik@neon.tech>
VladLazar pushed a commit that referenced this pull request Jul 8, 2024
Extracted from #6560, currently
we include multiple copies of aux files in the basebackup.

## Summary of changes

Fix the loop.

Signed-off-by: Alex Chi Z <chi@neon.tech>
Co-authored-by: Konstantin Knizhnik <knizhnik@neon.tech>
VladLazar pushed a commit that referenced this pull request Jul 8, 2024
Extracted from #6560, currently
we include multiple copies of aux files in the basebackup.

## Summary of changes

Fix the loop.

Signed-off-by: Alex Chi Z <chi@neon.tech>
Co-authored-by: Konstantin Knizhnik <knizhnik@neon.tech>
VladLazar pushed a commit that referenced this pull request Jul 8, 2024
Extracted from #6560, currently
we include multiple copies of aux files in the basebackup.

## Summary of changes

Fix the loop.

Signed-off-by: Alex Chi Z <chi@neon.tech>
Co-authored-by: Konstantin Knizhnik <knizhnik@neon.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants