Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase wait_lsn_timeout in test_wal_receiver.py #8129

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

petuhovskiy
Copy link
Member

In these tests wait_lsn_timeout was set to 1s which was too low. If something blinks (sk<->ps connection, sk activation, broker) during the test, the test will likely fail because of that. This commit changes the timeout to 3s which should be more stable.

I noticed this error when I made a PR for timeline_manager in safekeepers, this test was flaking because timeline activation was not instant.

Copy link

2904 tests run: 2784 passed, 3 failed, 117 skipped (full report)


Failures on Postgres 16

  • test_pageserver_lsn_wait_error_start: debug

Failures on Postgres 15

  • test_pageserver_lsn_wait_error_start: debug

Failures on Postgres 14

  • test_pageserver_lsn_wait_error_start: debug
# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_pageserver_lsn_wait_error_start[debug-pg14] or test_pageserver_lsn_wait_error_start[debug-pg15] or test_pageserver_lsn_wait_error_start[debug-pg16]"
Flaky tests (4)

Postgres 16

  • test_pageserver_lsn_wait_error_safekeeper_stop: debug

Postgres 15

  • test_location_conf_churn[3]: release
  • test_pageserver_lsn_wait_error_safekeeper_stop: debug

Postgres 14

  • test_pageserver_lsn_wait_error_safekeeper_stop: debug

Test coverage report is not available

The comment gets automatically updated with the latest test results
7fcc31c at 2024-06-21T15:49:21.411Z :recycle:

@petuhovskiy
Copy link
Member Author

Hmm, apparently increased timeout fails test_pageserver_lsn_wait_error_start. Not sure why.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant