Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update to rust 1.79 #8048

Merged
merged 5 commits into from
Jun 14, 2024
Merged

chore: update to rust 1.79 #8048

merged 5 commits into from
Jun 14, 2024

Conversation

conradludgate
Copy link
Contributor

Problem

rust 1.79 new enabled by default lints

Summary of changes

  • s/default_features/default-features/
  • fix proxy dead code.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@conradludgate conradludgate requested a review from a team as a code owner June 13, 2024 15:45
@conradludgate conradludgate requested a review from a team as a code owner June 13, 2024 15:57
@conradludgate conradludgate requested a review from jcsp June 13, 2024 15:57
jcsp
jcsp approved these changes Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@jcsp jcsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for pageserver

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 13, 2024 •
edited
Loading

3216 tests run: 3074 passed, 0 failed, 142 skipped (full report)

Flaky tests (1)

Postgres 16

  • test_storage_controller_smoke: debug

Code coverage* (full report)

  • functions: 31.5% (6636 of 21058 functions)
  • lines: 48.6% (51634 of 106264 lines)

* collected from Rust tests only

The comment gets automatically updated with the latest test results
a53db3a at 2024-06-13T21:39:31.127Z :recycle:

@conradludgate conradludgate enabled auto-merge (squash) June 13, 2024 19:41
@arpad-m arpad-m added the run-extra-build-macos When placed on a PR, tells the CI to run a build on macOS. No unit tests are run, though. label Jun 13, 2024
@conradludgate conradludgate changed the title proxy fix new clippy lints chore: update to rust 1.79 Jun 14, 2024
@conradludgate conradludgate merged commit e6eb002 into main Jun 14, 2024
64 checks passed
@conradludgate conradludgate deleted the proxy-fix-new-clippy-lints branch June 14, 2024 11:23
sharnoff added a commit to neondatabase/autoscaling that referenced this pull request Jun 18, 2024
@sharnoff
Update Rust: 1.78 -> 1.79
1d57f05 
Good to keep in sync with `neondatabase/neon` because we pull in
vm-monitor. Corresponding PR there was neondatabase/neon#8048.
@sharnoff sharnoff mentioned this pull request Jun 18, 2024
Merged
sharnoff added a commit to neondatabase/autoscaling that referenced this pull request Jun 19, 2024
@sharnoff
Update Rust: 1.78 -> 1.79 (#972)
8e7c0eb 
Good to keep in sync with `neondatabase/neon` because we pull in
vm-monitor. Corresponding PR there was neondatabase/neon#8048.
arpad-m added a commit that referenced this pull request Jul 25, 2024
@arpad-m
Update Rust to 1.80.0
67c3de5 
We keep the practice of keeping the compiler up to date, pointing to the
latest release. This is done by many other projects in the Rust
ecosystem as well.

[Release notes](https://github.com/rust-lang/rust/releases/tag/1.80.0).

Prior update was in #8048
@arpad-m arpad-m mentioned this pull request Jul 25, 2024
Merged
arpad-m added a commit that referenced this pull request Jul 26, 2024
@arpad-m
Update Rust to 1.80.0 (#8518)
bb2a3f9 
We keep the practice of keeping the compiler up to date, pointing to the
latest release. This is done by many other projects in the Rust ecosystem as well.

[Release notes](https://github.com/rust-lang/rust/blob/master/RELEASES.md#version-180-2024-07-25).

Prior update was in #8048
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcsp jcsp jcsp approved these changes

@arpad-m arpad-m arpad-m approved these changes

@khanova khanova khanova approved these changes

Assignees
No one assigned
Labels
run-extra-build-macos When placed on a PR, tells the CI to run a build on macOS. No unit tests are run, though.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@conradludgate @jcsp @arpad-m @khanova