Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy process updated errors #8026

Merged
merged 10 commits into from
Jun 13, 2024
Merged

Proxy process updated errors #8026

merged 10 commits into from
Jun 13, 2024

Conversation

khanova
Copy link
Contributor

@khanova khanova commented Jun 12, 2024

Problem

Respect errors classification from cplane

Summary of changes

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Copy link

github-actions bot commented Jun 12, 2024

3240 tests run: 3098 passed, 0 failed, 142 skipped (full report)


Flaky tests (6)

Postgres 15

  • test_storage_controller_smoke: debug

Postgres 14

  • test_pageserver_restarts_under_worload: release
  • test_secondary_background_downloads: release
  • test_slow_secondary_downloads[False]: release
  • test_subscriber_restart: release
  • test_wal_restore: release

Code coverage* (full report)

  • functions: 31.5% (6634 of 21054 functions)
  • lines: 48.5% (51522 of 106149 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
928404e at 2024-06-13T12:22:58.073Z :recycle:

@khanova khanova marked this pull request as ready for review June 12, 2024 09:24
@khanova khanova requested a review from a team as a code owner June 12, 2024 09:24
Copy link
Contributor

@conradludgate conradludgate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

proxy/src/console/provider/neon.rs Outdated Show resolved Hide resolved
Co-authored-by: Conrad Ludgate <conrad@neon.tech>
Co-authored-by: Conrad Ludgate <conrad@neon.tech>
@khanova khanova merged commit fbccd1e into main Jun 13, 2024
65 checks passed
@khanova khanova deleted the proxy-process-updated-errors branch June 13, 2024 12:42
save-buffer pushed a commit that referenced this pull request Jun 17, 2024
## Problem

Respect errors classification from cplane
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants