refactor: Timeline layer flushing #7993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koivunej
commented
Jun 7, 2024
3198 tests run: 3056 passed, 0 failed, 142 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
d9d5cbe at 2024-06-10T16:23:48.820Z :recycle: |
VladLazar
approved these changes
Jun 10, 2024
koivunej
commented
Jun 10, 2024
Base automatically changed from
joonas/another_attempt_at_flushing_and_pgvector
to
main
June 10, 2024 13:50
nothing in the regress suite is hitting it, and because LayerManager::try_freeze_whatever handles clearing out the TimelineWriterState, we should never even get stale TimelineWriterState.
koivunej
force-pushed
the
joonas/refactor_flushing
branch
from
3220aab
to
dbfd93b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new features have deteriorated layer flushing, most recently with #7927. Changes:
Timeline::freeze_inmem_layerto the only caller#[cfg(feature = "testing")]the assertion added in fix: allow layer flushes more often #7927flush_frozen_layerin favor of splitting theflush_frozen_layers_and_waitcheckpoint_distance < initdb sizetests