-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pageserver): collect aux file tombstones #7900
Conversation
3156 tests run: 3017 passed, 0 failed, 139 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
9f54d9e at 2024-05-31T19:19:50.563Z :recycle: |
ffc7279
to
474e494
Compare
f3f053e
to
d570e91
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving, but let's wait for @koivunej 's review as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am still antsy about "has_keys" being the wrong name. Think of a key range X with 50 keys deleted, 0 non-deleted. One would say "X is a key range with non-zero keys" or assert!(has_keys(X))
, which is different what we have with "wrote_any_image".
Approving for timezone diff, required:
- apply suggestion feat(pageserver): collect aux file tombstones #7900 (comment)
- I really think something must be done for
has_keys
which seems just wrong
Signed-off-by: Alex Chi Z <chi@neon.tech> add compaction tests Signed-off-by: Alex Chi Z <chi@neon.tech>
Signed-off-by: Alex Chi Z <chi@neon.tech>
d570e91
to
f03751d
Compare
Signed-off-by: Alex Chi Z <chi@neon.tech>
resolved comments :) |
Problem
close #7800
This is a small change to enable the tombstone -> exclude from image layer path. Most of the pull request is unit tests.
Summary of changes
Checklist before requesting a review
Checklist before merging