Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pageserver): collect aux file tombstones #7900

Merged
merged 3 commits into from
Jun 3, 2024
Merged

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented May 28, 2024

Problem

close #7800

This is a small change to enable the tombstone -> exclude from image layer path. Most of the pull request is unit tests.

Summary of changes

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Copy link

github-actions bot commented May 28, 2024

3156 tests run: 3017 passed, 0 failed, 139 skipped (full report)


Code coverage* (full report)

  • functions: 31.5% (6557 of 20804 functions)
  • lines: 48.5% (50696 of 104486 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
9f54d9e at 2024-05-31T19:19:50.563Z :recycle:

@skyzh skyzh marked this pull request as ready for review May 29, 2024 17:25
@skyzh skyzh requested a review from a team as a code owner May 29, 2024 17:25
@skyzh skyzh requested review from problame and removed request for a team May 29, 2024 17:25
pageserver/src/tenant.rs Outdated Show resolved Hide resolved
Copy link
Member

@arpad-m arpad-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving, but let's wait for @koivunej 's review as well

Copy link
Member

@koivunej koivunej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am still antsy about "has_keys" being the wrong name. Think of a key range X with 50 keys deleted, 0 non-deleted. One would say "X is a key range with non-zero keys" or assert!(has_keys(X)), which is different what we have with "wrote_any_image".

Approving for timezone diff, required:

Base automatically changed from skyzh/force-create-layers to main May 31, 2024 16:00
skyzh added 2 commits May 31, 2024 12:02
Signed-off-by: Alex Chi Z <chi@neon.tech>

add compaction tests

Signed-off-by: Alex Chi Z <chi@neon.tech>
Signed-off-by: Alex Chi Z <chi@neon.tech>
Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh
Copy link
Member Author

skyzh commented May 31, 2024

resolved comments :)

@skyzh skyzh merged commit c1f55c1 into main Jun 3, 2024
64 checks passed
@skyzh skyzh deleted the skyzh/delete-tombstones branch June 3, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

investigate delete tombstones over metadata keyspace
3 participants