Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[proxy] Do not fail after parquet upload error #7858

Merged
merged 2 commits into from
May 23, 2024

Conversation

khanova
Copy link
Contributor

@khanova khanova commented May 23, 2024

Problem

If the parquet upload was unsuccessful, it will panic.

Summary of changes

Write error in logs instead.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@khanova khanova requested review from a team as code owners May 23, 2024 08:24
@conradludgate
Copy link
Contributor

Looks good, but please fix up the postgres submodule changes

Copy link

github-actions bot commented May 23, 2024

3108 tests run: 2981 passed, 0 failed, 127 skipped (full report)


Code coverage* (full report)

  • functions: 31.4% (6450 of 20544 functions)
  • lines: 48.3% (49868 of 103274 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
46e4353 at 2024-05-23T09:52:26.984Z :recycle:

@khanova khanova removed the request for review from skyzh May 23, 2024 08:46
@khanova khanova removed the request for review from a team May 23, 2024 08:47
@khanova khanova enabled auto-merge (squash) May 23, 2024 08:55
@khanova khanova merged commit cd6d811 into main May 23, 2024
48 of 49 checks passed
@khanova khanova deleted the proxy-do-not-fail-on-parquet-upload-error branch May 23, 2024 09:41
khanova added a commit that referenced this pull request May 23, 2024
## Problem

If the parquet upload was unsuccessful, it will panic.

## Summary of changes

Write error in logs instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants