Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pageserver): make wal connstr a connstr #7846

Merged
merged 1 commit into from
May 23, 2024

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented May 22, 2024

Problem

The list timeline API gives something like "wal_source_connstr":"PgConnectionConfig { host: Domain(\"safekeeper-5.us-east-2.aws.neon.build\"), port: 6500, password: Some(REDACTED-STRING) }", which is weird. This pull request makes it somehow like a connection string. This field is not used at least in the neon database, so I assume no one is reading or parsing it.

Summary of changes

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh requested a review from a team as a code owner May 22, 2024 18:25
@skyzh skyzh requested review from problame and jcsp May 22, 2024 18:25
Copy link
Member

@koivunej koivunej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many parts of timeline detail are/is/exists just for debugging. I cannot see how this could hurt, the named debug output certainly was not useful.

Copy link

3108 tests run: 2982 passed, 0 failed, 126 skipped (full report)


Flaky tests (2)

Postgres 16

  • test_timeline_deletion_with_files_stuck_in_upload_queue: debug

Postgres 14

  • test_pageserver_init_node_id: debug

Code coverage* (full report)

  • functions: 31.4% (6446 of 20499 functions)
  • lines: 48.3% (49791 of 103171 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
03342c8 at 2024-05-22T19:15:02.132Z :recycle:

@skyzh skyzh merged commit e28e46f into main May 23, 2024
64 checks passed
@skyzh skyzh deleted the skyzh/walconnstr-questionmark branch May 23, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants