Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pageserver): use kebab case for aux file flag #7840

Merged
merged 2 commits into from
May 22, 2024
Merged

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented May 22, 2024

Problem

part of #7462

Summary of changes

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh requested a review from arpad-m May 22, 2024 14:26
@skyzh skyzh requested a review from a team as a code owner May 22, 2024 14:26
@arpad-m
Copy link
Member

arpad-m commented May 22, 2024

we should maybe do this for compaction as well, currently we use "Tiered" and "Legacy".

Copy link

github-actions bot commented May 22, 2024

3132 tests run: 3005 passed, 0 failed, 127 skipped (full report)


Flaky tests (2)

Postgres 15

  • test_crafted_wal_end[last_wal_record_xlog_switch_ends_on_page_boundary]: debug

Postgres 14

  • test_timeline_ancestor_errors: release

Code coverage* (full report)

  • functions: 31.4% (6416 of 20458 functions)
  • lines: 48.1% (49333 of 102645 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
1e7b758 at 2024-05-22T17:14:05.542Z :recycle:

Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh enabled auto-merge (squash) May 22, 2024 15:32
@skyzh skyzh merged commit ddd8ebd into main May 22, 2024
56 of 61 checks passed
@skyzh skyzh deleted the skyzh/aux-flag-kebab branch May 22, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants