Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rtc): maintain dirty and uploaded IndexPart #7833

Merged
merged 16 commits into from
Jun 4, 2024
Merged

feat(rtc): maintain dirty and uploaded IndexPart #7833

merged 16 commits into from
Jun 4, 2024

Commits on May 31, 2024

  1. wip: make rtc uploading more sensible

    @koivunej
    koivunej committed May 31, 2024
    Configuration menu
    Copy the full SHA
    3a483ff View commit details
    Browse the repository at this point in the history

  2. refactor: remove exploded fields

    @koivunej
    koivunej committed May 31, 2024
    Configuration menu
    Copy the full SHA
    203cd48 View commit details
    Browse the repository at this point in the history

  3. now original_ancestor_lsn queries are read-commited

    @koivunej
    koivunej committed May 31, 2024
    Configuration menu
    Copy the full SHA
    a26e674 View commit details
    Browse the repository at this point in the history

  4. get rid of unwrap 

    on serialization failure we are pretty much dead in the water, but as we
don't have a good way to make tenants broken on errors, we will stay
dead until error is detected.

of course the serialization should never fail, but...
    @koivunej
    koivunej committed May 31, 2024
    Configuration menu
    Copy the full SHA
    f0f574c View commit details
    Browse the repository at this point in the history

  5. fix: fixup the duplicated disk_consistent_lsn field

    @koivunej
    koivunej committed May 31, 2024
    Configuration menu
    Copy the full SHA
    6a8f671 View commit details
    Browse the repository at this point in the history

  6. fix: rename IndexPart::get_dcl => duplicated_dcl, stop using it 

    dcl = disk_consistent_lsn. it was only being used by mistake in http
endpoints and pagectl. it should only be used in scrubber.
    @koivunej
    koivunej committed May 31, 2024
    Configuration menu
    Copy the full SHA
    7023d20 View commit details
    Browse the repository at this point in the history

  7. doc: cleanup huge comment

    @koivunej
    koivunej committed May 31, 2024
    Configuration menu
    Copy the full SHA
    7c7b8e4 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2024

  1. rewrite to be about maintaining a "clean" indexpart

    @koivunej
    koivunej committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    2448bf3 View commit details
    Browse the repository at this point in the history

  2. fix: check that IndexPart serializes earlier 

    This reverts commit b202c4a35e71a32e1e67890cd3c931790a9b9f4b.
    @koivunej
    koivunej committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    668849c View commit details
    Browse the repository at this point in the history

  3. refactor: monotone

    @koivunej
    koivunej committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    2b70584 View commit details
    Browse the repository at this point in the history

  4. doc: remove XXX monotonicity check

    @koivunej
    koivunej committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    46186fe View commit details
    Browse the repository at this point in the history

  5. doc: describe the monotonicity check

    @koivunej
    koivunej committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    c0b8548 View commit details
    Browse the repository at this point in the history

  6. try: log monotonicity check fails with warn for now

    @koivunej
    koivunej committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    21cadeb View commit details
    Browse the repository at this point in the history

  7. fix: remove duplicated project_remote_consistent_lsn 

    it can now be read from UploadQueueInitialized::clean
    @koivunej
    koivunej committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    a130cc2 View commit details
    Browse the repository at this point in the history

  8. replace link

    @koivunej
    koivunej committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    6111cf1 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. fix: assert monotonicity 

    in a situation of continously having index uploads, those should
complete one by one and the completing should be the one spawning the
next task. this means we cannot race to the lock by multiple completing
index part uploads, which means we can turn the monotonicity check into
an assertion.
    @koivunej
    koivunej committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    a2463ca View commit details
    Browse the repository at this point in the history