refactor(test): duplication with fullbackup, tar content hashing #7828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koivunej
commented
May 21, 2024
3096 tests run: 2969 passed, 0 failed, 127 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
545c8df at 2024-05-21T21:31:41.083Z :recycle: |
koivunej
commented
May 21, 2024
Comment on lines
+26
to
+29
| # endpoint needs to be alive until the fullbackup so that we have | ||
| # prev_record_lsn for the vanilla_pg to start in read-write mode | ||
| # for some reason this does not happen if endpoint is shutdown. | ||
| endpoint_main = env.endpoints.create_start("main") |
There was a problem hiding this comment.
I do not understand this, it doesn't make any sense...
With previous version the prev_record_lsn was 0/0 and vanilla_pg refused to start (as expected): https://neon-github-public-dev.s3.amazonaws.com/reports/pr-7828/9178645043/index.html#suites/564b8e3fb116e6760ef9787f7b0225db/802b3bddaf6b4a1e/
arpad-m
approved these changes
May 22, 2024
koivunej
added a commit
that referenced
this pull request
May 23, 2024
With #7828 and proper fullbackup testing the test became flaky ([evidence]). - produce better assertion messages in `assert_pageserver_backups_equal` - use read only endpoint to confirm the row count [evidence]: https://neon-github-public-dev.s3.amazonaws.com/reports/pr-7839/9192447962/index.html#suites/89cfa994d71769e01e3fc4f475a1f3fa/49009214d0f8b8ce
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"taking a fullbackup" is an ugly multi-liner copypasted in multiple places, most recently with timeline ancestor detach tests. move it under
PgBinwhich is not a great place, but better than yet another utility function.Additionally:
psql_envrepetition (PgBin already configures that)test_import.pywhere a size check was done previouslyCc: #7715