-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(test): duplication with fullbackup, tar content hashing #7828
Conversation
3096 tests run: 2969 passed, 0 failed, 127 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
545c8df at 2024-05-21T21:31:41.083Z :recycle: |
# endpoint needs to be alive until the fullbackup so that we have | ||
# prev_record_lsn for the vanilla_pg to start in read-write mode | ||
# for some reason this does not happen if endpoint is shutdown. | ||
endpoint_main = env.endpoints.create_start("main") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not understand this, it doesn't make any sense...
With previous version the prev_record_lsn was 0/0 and vanilla_pg refused to start (as expected): https://neon-github-public-dev.s3.amazonaws.com/reports/pr-7828/9178645043/index.html#suites/564b8e3fb116e6760ef9787f7b0225db/802b3bddaf6b4a1e/
With #7828 and proper fullbackup testing the test became flaky ([evidence]). - produce better assertion messages in `assert_pageserver_backups_equal` - use read only endpoint to confirm the row count [evidence]: https://neon-github-public-dev.s3.amazonaws.com/reports/pr-7839/9192447962/index.html#suites/89cfa994d71769e01e3fc4f475a1f3fa/49009214d0f8b8ce
"taking a fullbackup" is an ugly multi-liner copypasted in multiple places, most recently with timeline ancestor detach tests. move it under
PgBin
which is not a great place, but better than yet another utility function.Additionally:
psql_env
repetition (PgBin already configures that)test_import.py
where a size check was done previouslyCc: #7715