Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI(promote-images): simplify & fix the job #7826

Merged
merged 6 commits into from
May 22, 2024
Merged

Conversation

bayandin
Copy link
Member

@bayandin bayandin commented May 21, 2024

Problem

Currently, latest tag is added to the images in several cases:

github.ref_name == 'main' || github.ref_name == 'release' || github.ref_name == 'release-proxy'

This leads to a race; the latest tag jumps back and forth depending on the branch that has built images.

Summary of changes

  • Do not push latest images to prod ECR (we don't use it)
  • Use docker buildx imagetools instead of crane for tagging images
  • Unify vm-compute-node-image job with others and use dockerhub as a first source for images (sync images with ECR)
  • Tag images with latest only for commits in main

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@bayandin bayandin added the run-e2e-tests-in-draft When placed on a PR, tells the CI to run e2e test in draft PR label May 21, 2024
Copy link

github-actions bot commented May 21, 2024

3102 tests run: 2976 passed, 0 failed, 126 skipped (full report)


Flaky tests (2)

Postgres 16

  • test_timeline_deletion_with_files_stuck_in_upload_queue: debug

Postgres 14

  • test_crafted_wal_end[last_wal_record_xlog_switch]: debug

Code coverage* (full report)

  • functions: 31.3% (6414 of 20478 functions)
  • lines: 48.0% (49312 of 102655 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
bd380a1 at 2024-05-22T15:13:29.035Z :recycle:

@bayandin bayandin force-pushed the bayandin/fix-promote-images branch from ca23b07 to 289e6f0 Compare May 22, 2024 11:21
@bayandin bayandin marked this pull request as ready for review May 22, 2024 13:24
@bayandin bayandin requested a review from fcdm May 22, 2024 13:43
.github/workflows/build_and_test.yml Outdated Show resolved Hide resolved
@bayandin bayandin enabled auto-merge (squash) May 22, 2024 14:30
@bayandin bayandin merged commit 325f378 into main May 22, 2024
51 of 52 checks passed
@bayandin bayandin deleted the bayandin/fix-promote-images branch May 22, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-e2e-tests-in-draft When placed on a PR, tells the CI to run e2e test in draft PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants